issue_comments

Table actions

13 rows where issue = 855330062 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • failing CI · 13 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
826390033 https://github.com/pydata/xarray/issues/5138#issuecomment-826390033 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgyNjM5MDAzMw== keewis 14808389 2021-04-25T21:06:52Z 2021-04-25T21:08:43Z MEMBER

both mamba create -n py39-mamba python=3.9 mamba mamba env update -n py39-mamba -f ci/requirements/environment.yml and conda create -n py39-conda python=3.9 conda env update -n py39-conda -f ci/requirements/environment.yml work for me (on linux), but mamba installs the wrong version of python-eccodes (build number 0 instead of number 1). Of course, there's lots of other differences (mostly different build hashes).

Edit: not sure if I didn't do anything wrong, though

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
826344428 https://github.com/pydata/xarray/issues/5138#issuecomment-826344428 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgyNjM0NDQyOA== alexamici 226037 2021-04-25T15:41:07Z 2021-04-25T15:41:07Z MEMBER

I don't know, I've never managed to get cfgrib and xarray to install on python 3.9. The conda solver fails.

It looks like there is a conflict between xarray and eccodes dependencies, but I didn't investigate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
826311657 https://github.com/pydata/xarray/issues/5138#issuecomment-826311657 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgyNjMxMTY1Nw== keewis 14808389 2021-04-25T11:54:06Z 2021-04-25T11:54:06Z MEMBER

@alexamici, I'm not sure why but mamba does not install the fixed build of python-eccodes on py39: /home/runner/work/xarray/xarray/xarray/backends/cfgrib_.py:27: UserWarning: Failed to load cfgrib - most likely there is a problem accessing the ecCodes library. Try `import cfgrib` to get the full error message

Do you have any idea how to fix that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
818024428 https://github.com/pydata/xarray/issues/5138#issuecomment-818024428 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxODAyNDQyOA== keewis 14808389 2021-04-12T18:17:50Z 2021-04-12T18:17:50Z MEMBER

thanks, @alexamici 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817864442 https://github.com/pydata/xarray/issues/5138#issuecomment-817864442 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzg2NDQ0Mg== alexamici 226037 2021-04-12T14:34:13Z 2021-04-12T14:34:13Z MEMBER

Yes, I would close the issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817732577 https://github.com/pydata/xarray/issues/5138#issuecomment-817732577 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzczMjU3Nw== keewis 14808389 2021-04-12T11:28:45Z 2021-04-12T11:28:45Z MEMBER

great. If this is nothing we have control over, should we close this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817566465 https://github.com/pydata/xarray/issues/5138#issuecomment-817566465 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzU2NjQ2NQ== alexamici 226037 2021-04-12T07:37:25Z 2021-04-12T07:37:25Z MEMBER

@keewis after merging #5139 the CI should not be failing anymore. The problem is now that cfgrib may not be consistently tested on all jobs and failures are silent.

I'll wait a bit for the fix in python-eccodes, otherwise I'll do a new release of the conda package of cfgrib.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817557923 https://github.com/pydata/xarray/issues/5138#issuecomment-817557923 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzU1NzkyMw== alexamici 226037 2021-04-12T07:25:03Z 2021-04-12T07:25:03Z MEMBER

Technically this is an incompatibility between python-eccodes and eccodes, I'm trying to resolve it via a PR to the python-eccodes-feedstock: https://github.com/conda-forge/python-eccodes-feedstock/pull/71

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817360245 https://github.com/pydata/xarray/issues/5138#issuecomment-817360245 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM2MDI0NQ== keewis 14808389 2021-04-11T19:32:44Z 2021-04-11T19:32:44Z MEMBER

To work around the current problem we may need to add a eccodes>=2.21.0 to the CI

agreed. If eccodes<2.21.0 is truly incompatible with the new version of cfgrib, you could also release a new build on conda-forge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817358999 https://github.com/pydata/xarray/issues/5138#issuecomment-817358999 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1ODk5OQ== alexamici 226037 2021-04-11T19:23:14Z 2021-04-11T19:28:45Z MEMBER

As a general measure I would add ImportError to the exception caught on import so we avoid to crash xarray:

https://github.com/pydata/xarray/blob/186c2ff6542f090a8e97ffb755f866030be30be9/xarray/backends/cfgrib_.py#L18-L29

To work around the current problem we may need to add a eccodes>=2.21.0 to the CI :/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817357498 https://github.com/pydata/xarray/issues/5138#issuecomment-817357498 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1NzQ5OA== alexamici 226037 2021-04-11T19:12:13Z 2021-04-11T19:12:30Z MEMBER

Thanks @keewis! ATM the main suspect is a flaky the dependency between python-eccodes and eccodes, not cfgrib itself. So it may look like a random error in CI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817356770 https://github.com/pydata/xarray/issues/5138#issuecomment-817356770 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1Njc3MA== keewis 14808389 2021-04-11T19:06:36Z 2021-04-11T19:06:36Z MEMBER

it is interesting that this only happens for py37 macos, py37 ubuntu and py39 ubuntu but nothing else.

Looking into ecmwf/cfgrib#226 that seems related.

That does indeed seem related but seems to use py38 which does not fail for us.

For reference, this is the traceback:

traceback ```pytb Traceback (most recent call last): File "<string>", line 1, in <module> File "/home/runner/work/xarray/xarray/xarray/__init__.py", line 3, in <module> from . import testing, tutorial, ufuncs File "/home/runner/work/xarray/xarray/xarray/tutorial.py", line 13, in <module> from .backends.api import open_dataset as _open_dataset File "/home/runner/work/xarray/xarray/xarray/backends/__init__.py", line 6, in <module> from .cfgrib_ import CfGribDataStore File "/home/runner/work/xarray/xarray/xarray/backends/cfgrib_.py", line 19, in <module> import cfgrib File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/cfgrib/__init__.py", line 19, in <module> from .cfmessage import CfMessage File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/cfgrib/cfmessage.py", line 29, in <module> from . import messages File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/cfgrib/messages.py", line 28, in <module> import eccodes # type: ignore File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/eccodes/__init__.py", line 15, in <module> from .eccodes import * File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/eccodes/eccodes.py", line 12, in <module> from gribapi import __version__ File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/gribapi/__init__.py", line 13, in <module> from .gribapi import * # noqa File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/gribapi/gribapi.py", line 32, in <module> from .bindings import ENC, ffi, lib File "/usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/gribapi/bindings.py", line 29, in <module> from ._bindings import ffi, lib ImportError: /usr/share/miniconda/envs/xarray-tests/lib/python3.9/site-packages/gribapi/_bindings.cpython-39-x86_64-linux-gnu.so: undefined symbol: codes_bufr_key_is_header ``` 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817355970 https://github.com/pydata/xarray/issues/5138#issuecomment-817355970 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1NTk3MA== alexamici 226037 2021-04-11T19:00:30Z 2021-04-11T19:00:30Z MEMBER

Looking into ecmwf/cfgrib#226 that seems related.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);