issue_comments

Table actions

15 rows where issue = 853644364 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 4

issue 1

  • Fix open_dataset regression · 15 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
820374206 https://github.com/pydata/xarray/pull/5135#issuecomment-820374206 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgyMDM3NDIwNg== alexamici 226037 2021-04-15T12:11:26Z 2021-04-15T12:11:26Z MEMBER

@bcbnz thanks for the help! I'll merge it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
820156925 https://github.com/pydata/xarray/pull/5135#issuecomment-820156925 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgyMDE1NjkyNQ== bcbnz 367900 2021-04-15T06:36:38Z 2021-04-15T06:36:38Z CONTRIBUTOR

@aurghs it fixes it for both the test script in #5132 (using all three netCDF engines, netcdf4, h5netcdf and scipy) and for my original unit tests where I found the problem.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
819563132 https://github.com/pydata/xarray/pull/5135#issuecomment-819563132 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxOTU2MzEzMg== aurghs 35919497 2021-04-14T14:29:59Z 2021-04-14T14:29:59Z COLLABORATOR

@bcbnz could you check if this fixes also #5132?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
818808309 https://github.com/pydata/xarray/pull/5135#issuecomment-818808309 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxODgwODMwOQ== aurghs 35919497 2021-04-13T15:03:39Z 2021-04-13T15:03:39Z COLLABORATOR

@aurghs can you confirm that all failures are unrelated to the changes?

In my understanding, the errors are not related to the changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
818806507 https://github.com/pydata/xarray/pull/5135#issuecomment-818806507 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxODgwNjUwNw== keewis 14808389 2021-04-13T15:01:27Z 2021-04-13T15:01:27Z MEMBER

@alexamici, that's #5147

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
818804036 https://github.com/pydata/xarray/pull/5135#issuecomment-818804036 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxODgwNDAzNg== alexamici 226037 2021-04-13T14:58:07Z 2021-04-13T14:58:07Z MEMBER

@aurghs can you confirm that all failures are unrelated to the changes?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
818467868 https://github.com/pydata/xarray/pull/5135#issuecomment-818467868 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxODQ2Nzg2OA== pep8speaks 24736507 2021-04-13T06:13:13Z 2021-04-13T06:24:37Z NONE

Hello @aurghs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-04-13 06:24:37 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816050897 https://github.com/pydata/xarray/pull/5135#issuecomment-816050897 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjA1MDg5Nw== aurghs 35919497 2021-04-08T18:37:46Z 2021-04-08T18:37:46Z COLLABORATOR

At this point, probably api.normalize_path is the best choice.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816032139 https://github.com/pydata/xarray/pull/5135#issuecomment-816032139 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAzMjEzOQ== bcbnz 367900 2021-04-08T18:10:58Z 2021-04-08T18:11:16Z CONTRIBUTOR

LGTM. I don't know how we would test this...

For ensuring absolute paths, my MVCE in #5132 could be adapted.

Expansion of ~ might be trickier, but the os.path.expanduser docstring says

On Unix, an initial ~ is replaced by the environment variable HOME if it is set

and

On Windows, USERPROFILE will be used if set

so tests run with appropriate environment variables could be used with OS checking.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816027472 https://github.com/pydata/xarray/pull/5135#issuecomment-816027472 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAyNzQ3Mg== alexamici 226037 2021-04-08T18:03:14Z 2021-04-08T18:03:14Z MEMBER

@aurghs you may also use _normalize_path that does all the checks:

https://github.com/pydata/xarray/blob/master/xarray/backends/api.py#L112

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816024426 https://github.com/pydata/xarray/pull/5135#issuecomment-816024426 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAyNDQyNg== bcbnz 367900 2021-04-08T17:58:23Z 2021-04-08T17:58:23Z CONTRIBUTOR

@aurghs & @dcherian note that at the moment most backends accept pathlib.Path (but it is not tested), so the isintance(..., str) doesn't run expandpath in that case.

What do you suggest?

For Python 3.6+ expanduser works with paths, returning a string:

```

os.path.expanduser(pathlib.Path("~/file.nc")) '/home/username/file.nc' ``` If its preferred to keep a Path instance, then the Path.expanduser method is the equivalent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816019678 https://github.com/pydata/xarray/pull/5135#issuecomment-816019678 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAxOTY3OA== alexamici 226037 2021-04-08T17:50:25Z 2021-04-08T17:54:36Z MEMBER

@aurghs & @dcherian note that at the moment most backends accept pathlib.Path (but it is not tested), so the isintance(..., str) doesn't run expanduser in that case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816021103 https://github.com/pydata/xarray/pull/5135#issuecomment-816021103 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAyMTEwMw== aurghs 35919497 2021-04-08T17:52:46Z 2021-04-08T17:52:46Z COLLABORATOR

LGTM. I don't know how we would test this...

I don't have any good idea about it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816013551 https://github.com/pydata/xarray/pull/5135#issuecomment-816013551 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAxMzU1MQ== dcherian 2448579 2021-04-08T17:40:34Z 2021-04-08T17:40:34Z MEMBER

LGTM. I don't know how we would test this...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816011259 https://github.com/pydata/xarray/pull/5135#issuecomment-816011259 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAxMTI1OQ== bcbnz 367900 2021-04-08T17:36:57Z 2021-04-08T17:36:57Z CONTRIBUTOR

I think this would also fix #5132 if os.path.abspath was added around the os.path.expanduser calls.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);