home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 816032139

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5135#issuecomment-816032139 https://api.github.com/repos/pydata/xarray/issues/5135 816032139 MDEyOklzc3VlQ29tbWVudDgxNjAzMjEzOQ== 367900 2021-04-08T18:10:58Z 2021-04-08T18:11:16Z CONTRIBUTOR

LGTM. I don't know how we would test this...

For ensuring absolute paths, my MVCE in #5132 could be adapted.

Expansion of ~ might be trickier, but the os.path.expanduser docstring says

On Unix, an initial ~ is replaced by the environment variable HOME if it is set

and

On Windows, USERPROFILE will be used if set

so tests run with appropriate environment variables could be used with OS checking.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  853644364
Powered by Datasette · Queries took 0.796ms · About: xarray-datasette