issue_comments

Table actions

8 rows where issue = 847489988 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Surface plots · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
831246904 https://github.com/pydata/xarray/pull/5101#issuecomment-831246904 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgzMTI0NjkwNA== mathause 10194086 2021-05-03T13:05:47Z 2021-05-03T13:05:59Z MEMBER

Once again, thanks a lot for your contribution @johnomotani! (the test failure is unrelated)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
811959862 https://github.com/pydata/xarray/pull/5101#issuecomment-811959862 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgxMTk1OTg2Mg== pep8speaks 24736507 2021-04-01T14:48:03Z 2021-05-03T12:06:43Z NONE

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-03 12:06:43 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
829239055 https://github.com/pydata/xarray/pull/5101#issuecomment-829239055 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgyOTIzOTA1NQ== johnomotani 3958036 2021-04-29T13:29:55Z 2021-04-29T14:43:04Z CONTRIBUTOR

One thing that could be nice is an example in http://xarray.pydata.org/en/stable/plotting.html - up to you.

It seemed odd to add a surface example when contour and countourf weren't shown - so I've added a new subsection for 'Other types of plot' and shown all three.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
828034654 https://github.com/pydata/xarray/pull/5101#issuecomment-828034654 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgyODAzNDY1NA== johnomotani 3958036 2021-04-27T23:51:19Z 2021-04-27T23:51:19Z CONTRIBUTOR

Thanks @mathause - master merged now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
823576115 https://github.com/pydata/xarray/pull/5101#issuecomment-823576115 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgyMzU3NjExNQ== Illviljan 14371165 2021-04-20T20:23:30Z 2021-04-20T20:23:55Z MEMBER

I think you can remove all those matplotlib checks if you do something like this:

```python subplot_kws = dict() if ax is None: # TODO: Importing Axes3D is not necessary in matplotlib >= 3.2. # Remove when minimum requirement of matplotlib is 3.2: from mpl_toolkits.mplot3d import Axes3D # type: ignore # noqa

    subplot_kws.update(projection="3d")

```

I got stuck with the same thing in #4909. Importing Axes3D was the the standard way of turning on the 3d plotting functionalities. Now with newer releases it's not necessary anymore, but it's a backwards friendly way of doing it for a while longer.

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
812012953 https://github.com/pydata/xarray/pull/5101#issuecomment-812012953 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgxMjAxMjk1Mw== johnomotani 3958036 2021-04-01T16:10:01Z 2021-04-01T16:10:01Z CONTRIBUTOR

Tests pass! Think this is ready for review now @pydata/xarray

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
811935990 https://github.com/pydata/xarray/pull/5101#issuecomment-811935990 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgxMTkzNTk5MA== johnomotani 3958036 2021-04-01T14:11:35Z 2021-04-01T14:11:35Z CONTRIBUTOR

Seems like the way I've implemented surface plots requires a slightly newer version than the oldest supported matplotlib to use the "3d" projection. matplotlib-3.2.0 basically works, but some of the unit tests require matpltolib-3.3.0 to pass. I'll try to add a check and skip some tests where necessary.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988
811519561 https://github.com/pydata/xarray/pull/5101#issuecomment-811519561 https://api.github.com/repos/pydata/xarray/issues/5101 MDEyOklzc3VlQ29tbWVudDgxMTUxOTU2MQ== johnomotani 3958036 2021-03-31T22:59:59Z 2021-03-31T22:59:59Z CONTRIBUTOR

Note, this PR includes the bugfix in #5099, because it needed to build on that change. #5099 is smaller, so I guess it will naturally be merged first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Surface plots 847489988

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);