issue_comments: 823576115
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/5101#issuecomment-823576115 | https://api.github.com/repos/pydata/xarray/issues/5101 | 823576115 | MDEyOklzc3VlQ29tbWVudDgyMzU3NjExNQ== | 14371165 | 2021-04-20T20:23:30Z | 2021-04-20T20:23:55Z | MEMBER | I think you can remove all those matplotlib checks if you do something like this: ```python subplot_kws = dict() if ax is None: # TODO: Importing Axes3D is not necessary in matplotlib >= 3.2. # Remove when minimum requirement of matplotlib is 3.2: from mpl_toolkits.mplot3d import Axes3D # type: ignore # noqa ``` I got stuck with the same thing in #4909. Importing Axes3D was the the standard way of turning on the 3d plotting functionalities. Now with newer releases it's not necessary anymore, but it's a backwards friendly way of doing it for a while longer. |
{
"total_count": 2,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
847489988 |