issue_comments

Table actions

10 rows where issue = 841476745 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • ⚠️ Nightly upstream-dev CI failed ⚠️ · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
844127804 https://github.com/pydata/xarray/issues/5077#issuecomment-844127804 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDg0NDEyNzgwNA== keewis 14808389 2021-05-19T13:52:42Z 2021-05-19T13:52:42Z MEMBER

I've opened #5344 for the nc-time-axis / cftime issue and xfail'ed it in #5343. Closing to get notifications for other upstream-dev issues (once the CI works again).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
832359943 https://github.com/pydata/xarray/issues/5077#issuecomment-832359943 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgzMjM1OTk0Mw== dcherian 2448579 2021-05-05T01:38:42Z 2021-05-05T01:38:42Z MEMBER

```

      if layer.collection_annotations is None:

E AttributeError: 'dict' object has no attribute 'collection_annotations' ```

This looks like it comes from our HighLevelGraph manipulations here https://github.com/pydata/xarray/blob/f455e00f0228c30423123c089227d7a8fd4a94b5/xarray/core/parallel.py#L529-L546

Maybe @crusaderky or @jrbourbeau can tell us what's going wrong?

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
830829852 https://github.com/pydata/xarray/issues/5077#issuecomment-830829852 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgzMDgyOTg1Mg== keewis 14808389 2021-05-02T15:49:44Z 2021-05-02T15:50:01Z MEMBER

we should try to resolve this before the release

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
830736833 https://github.com/pydata/xarray/issues/5077#issuecomment-830736833 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgzMDczNjgzMw== andersy005 13301940 2021-05-02T04:13:39Z 2021-05-02T04:13:39Z MEMBER

As of 3 days ago (April 29th), it appears that there are some outstanding issues with dask that need to be resolved, too

bash FAILED xarray/tests/test_dask.py::test_map_blocks_error - AttributeError: 'di... FAILED xarray/tests/test_dask.py::test_map_blocks[obj0] - AttributeError: 'di... FAILED xarray/tests/test_dask.py::test_map_blocks[obj1] - AttributeError: 'di... FAILED xarray/tests/test_dask.py::test_map_blocks_convert_args_to_list[obj0] FAILED xarray/tests/test_dask.py::test_map_blocks_convert_args_to_list[obj1] FAILED xarray/tests/test_dask.py::test_map_blocks_dask_args - AttributeError:... FAILED xarray/tests/test_dask.py::test_map_blocks_add_attrs[obj0] - Attribute... FAILED xarray/tests/test_dask.py::test_map_blocks_add_attrs[obj1] - Attribute... FAILED xarray/tests/test_dask.py::test_map_blocks_change_name - AttributeErro... FAILED xarray/tests/test_dask.py::test_map_blocks_kwargs[obj0] - AttributeErr... FAILED xarray/tests/test_dask.py::test_map_blocks_kwargs[obj1] - AttributeErr... FAILED xarray/tests/test_dask.py::test_map_blocks_to_array - AttributeError: ... FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>0] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>1] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>2] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>3] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>4] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>5] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>6] FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>7] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>0] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>1] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>2] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>3] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>4] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>5] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>6] FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>7] FAILED xarray/tests/test_dask.py::test_map_blocks_da_ds_with_template[obj0] FAILED xarray/tests/test_dask.py::test_map_blocks_da_ds_with_template[obj1] FAILED xarray/tests/test_dask.py::test_map_blocks_template_convert_object - A... FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template[obj0] FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template[obj1] FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template_2 - Att... FAILED xarray/tests/test_dask.py::test_map_blocks_object_method[obj0] - Attri... FAILED xarray/tests/test_dask.py::test_map_blocks_object_method[obj1] - Attri...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
811782335 https://github.com/pydata/xarray/issues/5077#issuecomment-811782335 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgxMTc4MjMzNQ== spencerkclark 6628425 2021-04-01T09:30:10Z 2021-04-01T09:30:10Z MEMBER

Yes, they need to be fixed upstream, either in nc-time-axis or cftime.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
811074709 https://github.com/pydata/xarray/issues/5077#issuecomment-811074709 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgxMTA3NDcwOQ== mathause 10194086 2021-03-31T13:37:21Z 2021-03-31T13:37:21Z MEMBER

The other issues have to be fixed in cftime, right?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
808404576 https://github.com/pydata/xarray/issues/5077#issuecomment-808404576 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgwODQwNDU3Ng== mathause 10194086 2021-03-26T17:43:28Z 2021-03-30T07:32:59Z MEMBER

Minimal example:

```python import pandas as pd import cftime

time_1 = cftime.DatetimeGregorian(2000, 1, 1) time_2 = cftime.DatetimeProlepticGregorian(2001, 1, 1)

s = pd.Series([time_1, time_2])

s.rank(method="dense", numeric_only=False) ```

https://github.com/pydata/xarray/blob/643e89ee7201e8bc730dcde19c3dc1c34fbd1ed5/xarray/core/combine.py#L96 https://github.com/pydata/xarray/blob/643e89ee7201e8bc730dcde19c3dc1c34fbd1ed5/xarray/tests/test_combine.py#L856

Edit: To clarify - the example is supposed to raise a TypeError. For cftime master it raises a ValueError which pandas ignores.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
808605313 https://github.com/pydata/xarray/issues/5077#issuecomment-808605313 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgwODYwNTMxMw== spencerkclark 6628425 2021-03-27T00:38:53Z 2021-03-27T00:38:53Z MEMBER

FAILED xarray/tests/test_combine.py::test_combine_by_coords_raises_for_differing_calendars

Thanks for tracking this down @mathause and opening the issue upstream!

FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_line_plot FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_pcolormesh_plot FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_contour_plot

It looks like https://github.com/Unidata/cftime/pull/235 may have broken some code in nc-time-axis. I'll open an issue in cftime tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
808403420 https://github.com/pydata/xarray/issues/5077#issuecomment-808403420 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgwODQwMzQyMA== mathause 10194086 2021-03-26T17:41:30Z 2021-03-26T17:41:30Z MEMBER

See Unidata/cftime#236

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745
808330485 https://github.com/pydata/xarray/issues/5077#issuecomment-808330485 https://api.github.com/repos/pydata/xarray/issues/5077 MDEyOklzc3VlQ29tbWVudDgwODMzMDQ4NQ== keewis 14808389 2021-03-26T15:58:01Z 2021-03-26T15:58:01Z MEMBER

cc @spencerkclark

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 841476745

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);