issue_comments: 808404576

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5077#issuecomment-808404576 https://api.github.com/repos/pydata/xarray/issues/5077 808404576 MDEyOklzc3VlQ29tbWVudDgwODQwNDU3Ng== 10194086 2021-03-26T17:43:28Z 2021-03-30T07:32:59Z MEMBER

Minimal example:

```python import pandas as pd import cftime

time_1 = cftime.DatetimeGregorian(2000, 1, 1) time_2 = cftime.DatetimeProlepticGregorian(2001, 1, 1)

s = pd.Series([time_1, time_2])

s.rank(method="dense", numeric_only=False) ```

https://github.com/pydata/xarray/blob/643e89ee7201e8bc730dcde19c3dc1c34fbd1ed5/xarray/core/combine.py#L96 https://github.com/pydata/xarray/blob/643e89ee7201e8bc730dcde19c3dc1c34fbd1ed5/xarray/tests/test_combine.py#L856

Edit: To clarify - the example is supposed to raise a TypeError. For cftime master it raises a ValueError which pandas ignores.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   841476745