issue_comments

Table actions

3 rows where issue = 837243943 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 3 ✖

issue 1

  • Zarr chunking fixes · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
826984456 https://github.com/pydata/xarray/pull/5065#issuecomment-826984456 https://api.github.com/repos/pydata/xarray/issues/5065 MDEyOklzc3VlQ29tbWVudDgyNjk4NDQ1Ng== dcherian 2448579 2021-04-26T16:37:37Z 2021-04-26T16:37:37Z MEMBER

Thanks @rabernat 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr chunking fixes 837243943
811262328 https://github.com/pydata/xarray/pull/5065#issuecomment-811262328 https://api.github.com/repos/pydata/xarray/issues/5065 MDEyOklzc3VlQ29tbWVudDgxMTI2MjMyOA== dcherian 2448579 2021-03-31T17:12:55Z 2021-03-31T17:12:55Z MEMBER

The problem is, I can't figure out where this happens.

Replace self._encoding with None here? https://github.com/pydata/xarray/blob/ddc352faa6de91f266a1749773d08ae8d6f09683/xarray/core/variable.py#L1084

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr chunking fixes 837243943
807120861 https://github.com/pydata/xarray/pull/5065#issuecomment-807120861 https://api.github.com/repos/pydata/xarray/issues/5065 MDEyOklzc3VlQ29tbWVudDgwNzEyMDg2MQ== dcherian 2448579 2021-03-25T17:13:55Z 2021-03-25T17:13:55Z MEMBER

Xarray knows to drop the dtype encoding after an arithmetic operation. How does that work?

There's a subtle difference. It drops all of .encoding not dtype specifically.

@shoyer's point about indexing changing chunking is a good one too. Perhaps a kwarg in to_zarr like ignore_encoding_chunks?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr chunking fixes 837243943

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);