issue_comments

Table actions

4 rows where issue = 834509559 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Error message when trying to concatenate DataSet and DataArray · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
850590181 https://github.com/pydata/xarray/issues/5051#issuecomment-850590181 https://api.github.com/repos/pydata/xarray/issues/5051 MDEyOklzc3VlQ29tbWVudDg1MDU5MDE4MQ== thomashirtz 37740986 2021-05-28T18:20:39Z 2021-05-28T18:20:39Z CONTRIBUTOR

@max-sixty I did my first pull request here, let me know if it is alright :) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error message when trying to concatenate DataSet and DataArray 834509559
845339856 https://github.com/pydata/xarray/issues/5051#issuecomment-845339856 https://api.github.com/repos/pydata/xarray/issues/5051 MDEyOklzc3VlQ29tbWVudDg0NTMzOTg1Ng== thomashirtz 37740986 2021-05-20T17:52:37Z 2021-05-20T17:52:37Z CONTRIBUTOR

I almost never contributed to someone else's project before on github, however I watched several tutorials.

It does make sense! I'll let you know in this thread if I really can't figure a step Thanks :)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error message when trying to concatenate DataSet and DataArray 834509559
845276125 https://github.com/pydata/xarray/issues/5051#issuecomment-845276125 https://api.github.com/repos/pydata/xarray/issues/5051 MDEyOklzc3VlQ29tbWVudDg0NTI3NjEyNQ== max-sixty 5635139 2021-05-20T16:38:02Z 2021-05-20T16:38:02Z MEMBER

That would be great @thomashirtz .

Have you contributed to a project on GitHub before? Assuming you're familiar with the process, I would a) add a check for types in the _dataset_concat function raising a better error message if a DataArray is supplied (or wherever looks better, I haven't looked in depth) and b) write a test that checks for the error message.

Does that make sense? Feel free to post back with anything half-baked and people can guide you.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error message when trying to concatenate DataSet and DataArray 834509559
845012399 https://github.com/pydata/xarray/issues/5051#issuecomment-845012399 https://api.github.com/repos/pydata/xarray/issues/5051 MDEyOklzc3VlQ29tbWVudDg0NTAxMjM5OQ== thomashirtz 37740986 2021-05-20T11:36:13Z 2021-05-20T11:36:13Z CONTRIBUTOR

I would like to start contributing to the xarray library (it would be my first contribution), I figure I can start by trying to make this error message. But I am not sure what is the best error message/best implementation. If anyone have some advise for this specific problem, it would be very welcome :) (ping @dcherian because of our discussion)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error message when trying to concatenate DataSet and DataArray 834509559

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);