home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 845276125

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5051#issuecomment-845276125 https://api.github.com/repos/pydata/xarray/issues/5051 845276125 MDEyOklzc3VlQ29tbWVudDg0NTI3NjEyNQ== 5635139 2021-05-20T16:38:02Z 2021-05-20T16:38:02Z MEMBER

That would be great @thomashirtz .

Have you contributed to a project on GitHub before? Assuming you're familiar with the process, I would a) add a check for types in the _dataset_concat function raising a better error message if a DataArray is supplied (or wherever looks better, I haven't looked in depth) and b) write a test that checks for the error message.

Does that make sense? Feel free to post back with anything half-baked and people can guide you.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  834509559
Powered by Datasette · Queries took 1.66ms · About: xarray-datasette