issue_comments

My guess is that this started to fail because we moved the setup_requires entry to pyproject.toml, which means that if you don't use that you have to take care of the build dependencies yourself.

Current versions of setuptools use pip instead of easy_install, so moving the setup_requires back would result in setup.py reporting an error when it cannot find setuptools_scm and pip is not installed in the build chroot.

The pyproject.toml build-system.requires is not exclusive; PEP 517 <build-backend>.get_requires_for_build_wheel() will be added to it to create the complete list of build requirements; the pyproject.toml build-system.requires is only needed to bootstrap the build backend itself.

And since the build backend when run on its own does not support pyproject.toml, but setuptools_scm is an internal implementation detail of the build backend and NOT of the PEP 517 part of the story... I'd personally say that it belongs in setup.cfg setup_requires rather than pyproject.toml

YMMV

Thanks to both of you as well as @eli-schwartz, it was indeed setuptools-scm missing (and apparently had been since 0.15.0, but previous setuptools version were silently downloading it through easy_install it seems).

We should not be using build in arch packaging yet as other team members do not like pip as a wheel installer. We are working on that in https://github.com/pradyunsg/installer.

Can you see if setting SETUPTOOLS_SCM_PRETEND_VERSION solves your issue? https://github.com/archlinux/svntogit-community/blob/d5d26f0836c57a20cbd6162a301c78ea60fc0845/trunk/PKGBUILD#L20

If setuptools-scm can't find a version I don't understand why it isn't falling back to 999. @keewis, did anyone actually test this change? https://github.com/pydata/xarray/blob/master/setup.py#L4

If what I said doesn't work, please try adding python-toml to makedepends so that setuptools picks up pyproject.toml.

That is fine. @ArchangeGabriel this should be solved by adding python-setuptools-scm to makedepends and then either building from git or a PyPI tarball (sdist) or setting SETUPTOOLS_SCM_PRETEND_VERSION.

I don't understand why it isn't falling back to 999

I can reproduce the failure in an environment without setuptools-scm. If I install it everything works as expected. My guess is that this started to fail because we moved the setup_requires entry to pyproject.toml, which means that if you don't use that you have to take care of the build dependencies yourself.

actually, it seems you can use python setup.py install --prefix $PREFIX if you have setuptools_scm installed. You'll find other build time dependencies in pyproject.toml.

I’ve used the one from Pypi.

I’ll check with @FFY00 whether I should be switching to build then.

Where did you get the tarball from? If you used the one from github you need to use a PEP517 frontend (e.g. build or pip) to build the actual tarball: setuptools_scm_git_archive is only mentioned in pyproject.toml.

Actually while disabling tests and keeping on packaging, I indeed see a reported version of 0.0.0 for xarray. Our diff checker grabbed this: usr/lib/python3.9/site-packages/xarray-0.16.2-py3.9.egg-info/ | usr/lib/python3.9/site-packages/xarray-0.0.0-py3.9.egg-info/ So maybe there is something wrong in the 0.17.0 tarball?

It’s not installed, I’m building it from source. So I run those command from within the cloned tarball: python setup.py build pytest --deselect xarray/tests/test_distributed.py::test_serializable_locks

Thanks for the report. Can you say more about how you installed Xarray?