issue_comments: 800572482

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5038#issuecomment-800572482 https://api.github.com/repos/pydata/xarray/issues/5038 800572482 MDEyOklzc3VlQ29tbWVudDgwMDU3MjQ4Mg== 6551424 2021-03-16T20:15:38Z 2021-03-16T20:15:38Z NONE

My guess is that this started to fail because we moved the setup_requires entry to pyproject.toml, which means that if you don't use that you have to take care of the build dependencies yourself.

Current versions of setuptools use pip instead of easy_install, so moving the setup_requires back would result in setup.py reporting an error when it cannot find setuptools_scm and pip is not installed in the build chroot.

The pyproject.toml build-system.requires is not exclusive; PEP 517 <build-backend>.get_requires_for_build_wheel() will be added to it to create the complete list of build requirements; the pyproject.toml build-system.requires is only needed to bootstrap the build backend itself.

And since the build backend when run on its own does not support pyproject.toml, but setuptools_scm is an internal implementation detail of the build backend and NOT of the PEP 517 part of the story... I'd personally say that it belongs in setup.cfg setup_requires rather than pyproject.toml

YMMV

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   832404698