issue_comments
3 rows where issue = 831008649 and user = 226037 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
issue 1
- Allow using a custom engine class directly in xr.open_dataset · 3 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
816258482 | https://github.com/pydata/xarray/pull/5033#issuecomment-816258482 | https://api.github.com/repos/pydata/xarray/issues/5033 | MDEyOklzc3VlQ29tbWVudDgxNjI1ODQ4Mg== | alexamici 226037 | 2021-04-08T22:01:50Z | 2021-04-08T22:07:27Z | MEMBER |
Absolutely agree: https://github.com/corteva/rioxarray/blob/master/rioxarray/xarray_plugin.py (the PR took a grand total of 48 hours from open to merge: https://github.com/corteva/rioxarray/pull/281)
😅 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow using a custom engine class directly in xr.open_dataset 831008649 | |
816173649 | https://github.com/pydata/xarray/pull/5033#issuecomment-816173649 | https://api.github.com/repos/pydata/xarray/issues/5033 | MDEyOklzc3VlQ29tbWVudDgxNjE3MzY0OQ== | alexamici 226037 | 2021-04-08T20:41:29Z | 2021-04-08T20:41:29Z | MEMBER |
Well, based on the amount of complexity a developer needs to master in order to write the backend, I would consider the registration to be a relatively trivial bit, especially because the syntax is the same as for the well known On one hand I judge the feature to be relatively simple to support in the long long term, on the other hand I still feel that its benefit will be be quite marginal. Therefore I'm still a mild -1.
On this one I can side with you. The initial proposal from @aurghs and myself was to use a This one is a higher lever design decisione, I think @jhamman and @shoyer need to weight in. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow using a custom engine class directly in xr.open_dataset 831008649 | |
815841228 | https://github.com/pydata/xarray/pull/5033#issuecomment-815841228 | https://api.github.com/repos/pydata/xarray/issues/5033 | MDEyOklzc3VlQ29tbWVudDgxNTg0MTIyOA== | alexamici 226037 | 2021-04-08T13:49:55Z | 2021-04-08T13:49:55Z | MEMBER | @Illviljan sorry for being late to the party. The first comment is that I see the point of the feature at a theoretical level, but I'm at the third external backend that I'm writing and I didn't miss it. Adding an entrypoint is very easy and works seamlessly during development. Do you have in mind any use case where this is more convenient than adding an entrypoint? WRT the implementation, at the request of @shoyer and @jhamman, we ask backend developers to inherit from |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow using a custom engine class directly in xr.open_dataset 831008649 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 1