home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 815841228

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5033#issuecomment-815841228 https://api.github.com/repos/pydata/xarray/issues/5033 815841228 MDEyOklzc3VlQ29tbWVudDgxNTg0MTIyOA== 226037 2021-04-08T13:49:55Z 2021-04-08T13:49:55Z MEMBER

@Illviljan sorry for being late to the party.

The first comment is that I see the point of the feature at a theoretical level, but I'm at the third external backend that I'm writing and I didn't miss it. Adding an entrypoint is very easy and works seamlessly during development.

Do you have in mind any use case where this is more convenient than adding an entrypoint?

WRT the implementation, at the request of @shoyer and @jhamman, we ask backend developers to inherit from BackendEntrypoint, for the sake of consistency I would enforce it here as well, instead to use duck-typing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  831008649
Powered by Datasette · Queries took 0.664ms · About: xarray-datasette