issue_comments

Table actions

2 rows where issue = 831008649 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Allow using a custom engine class directly in xr.open_dataset · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
819976858 https://github.com/pydata/xarray/pull/5033#issuecomment-819976858 https://api.github.com/repos/pydata/xarray/issues/5033 MDEyOklzc3VlQ29tbWVudDgxOTk3Njg1OA== shoyer 1217238 2021-04-15T02:02:10Z 2021-04-15T02:02:10Z MEMBER

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow using a custom engine class directly in xr.open_dataset 831008649
819671545 https://github.com/pydata/xarray/pull/5033#issuecomment-819671545 https://api.github.com/repos/pydata/xarray/issues/5033 MDEyOklzc3VlQ29tbWVudDgxOTY3MTU0NQ== shoyer 1217238 2021-04-14T16:58:52Z 2021-04-14T16:58:52Z MEMBER

My perspective:

  • Generally I like this PR. This is a nice, more explicit alternative to registering an entry-point.
  • I do think we should require using a subclass of Xarray's BackendEntrypoint. Subclassing is a standard way to express interfaces in Python. It is less error prone than supporting a dict, for example, which can more easily have misspelled names.
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow using a custom engine class directly in xr.open_dataset 831008649

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);