issue_comments: 819671545

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5033#issuecomment-819671545 https://api.github.com/repos/pydata/xarray/issues/5033 819671545 MDEyOklzc3VlQ29tbWVudDgxOTY3MTU0NQ== 1217238 2021-04-14T16:58:52Z 2021-04-14T16:58:52Z MEMBER

My perspective:

  • Generally I like this PR. This is a nice, more explicit alternative to registering an entry-point.
  • I do think we should require using a subclass of Xarray's BackendEntrypoint. Subclassing is a standard way to express interfaces in Python. It is less error prone than supporting a dict, for example, which can more easily have misspelled names.
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   831008649