issue_comments

Table actions

3 rows where issue = 807764700 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • mathause · 3 ✖

issue 1

  • add typing to unary and binary arithmetic operators · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
789898568 https://github.com/pydata/xarray/pull/4904#issuecomment-789898568 https://api.github.com/repos/pydata/xarray/issues/4904 MDEyOklzc3VlQ29tbWVudDc4OTg5ODU2OA== mathause 10194086 2021-03-03T17:13:08Z 2021-03-03T17:13:08Z MEMBER

Just FYI #4881 and #4878 are done

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add typing to unary and binary arithmetic operators 807764700
779710237 https://github.com/pydata/xarray/pull/4904#issuecomment-779710237 https://api.github.com/repos/pydata/xarray/issues/4904 MDEyOklzc3VlQ29tbWVudDc3OTcxMDIzNw== mathause 10194086 2021-02-16T09:37:55Z 2021-02-16T09:37:55Z MEMBER

Thanks for your thought-out answer. That all sounds good to me.

overlapping overload signatures with incompatible return types

So that works now? I remember vaguely that @max-sixty (?) had an issue with this pattern once.

Agreed. What name would work in this case? Something like OtherType or just Other (or ScalarOrArray)? Anything else?

I vote for ScalarOrArray.

Currently I have found no way to add meaningful type hints for these dynamically added attributes on the DataArray or Dataset classes

Yes, I think that's a problem of the __setattr__ and __getattr__ pattern. I don't have a strong opinion on the subclassing issue & both (bound TypeVars or just "Dataset") are fine for me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add typing to unary and binary arithmetic operators 807764700
778842603 https://github.com/pydata/xarray/pull/4904#issuecomment-778842603 https://api.github.com/repos/pydata/xarray/issues/4904 MDEyOklzc3VlQ29tbWVudDc3ODg0MjYwMw== mathause 10194086 2021-02-14T21:12:02Z 2021-02-14T21:12:02Z MEMBER

Thanks for the PR & your work. I'll need some time to digest that all... One thing I certainly would like to fix before merging this is #4881 (and merge #4878). I'd also be interested in your motivation for the stub files. (It's just that we don't have any of these so far).

I am sure you saw this comment:

https://github.com/pydata/xarray/blob/3681b6508d765b1b477f51963365807a85b53d89/xarray/core/ops.py#L3-L5

so there would be an argument to create mixin-classes*. Another motivation would be that currently (with the inject approach) mypy does not know which methods DataArray actually has. This is kind of hidden by __getattr__ (see #4601 & #4616). Now I am not saying you have to do this here but also wanted to mention it.

* Well I just realised that your stub files are kind of mixin classes...

  • What are all the # type: ignore[misc] you are suppressing?
  • I was slightly confused by the T_ of T_Other etc because this is not a TypeVar (but an alias) so I'd prefer another name.
  • For T_Dataset = TypeVar("T_Dataset", bound=Dataset) etc - why do you use a bound? To allow subclassing? As we discourage subclassing we may have to discuss if we should allow this.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add typing to unary and binary arithmetic operators 807764700

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);