issue_comments: 779710237

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4904#issuecomment-779710237 https://api.github.com/repos/pydata/xarray/issues/4904 779710237 MDEyOklzc3VlQ29tbWVudDc3OTcxMDIzNw== 10194086 2021-02-16T09:37:55Z 2021-02-16T09:37:55Z MEMBER

Thanks for your thought-out answer. That all sounds good to me.

overlapping overload signatures with incompatible return types

So that works now? I remember vaguely that @max-sixty (?) had an issue with this pattern once.

Agreed. What name would work in this case? Something like OtherType or just Other (or ScalarOrArray)? Anything else?

I vote for ScalarOrArray.

Currently I have found no way to add meaningful type hints for these dynamically added attributes on the DataArray or Dataset classes

Yes, I think that's a problem of the __setattr__ and __getattr__ pattern. I don't have a strong opinion on the subclassing issue & both (bound TypeVars or just "Dataset") are fine for me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   807764700