issue_comments

Table actions

14 rows where issue = 801728730 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • apply to dataset · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
892746284 https://github.com/pydata/xarray/pull/4863#issuecomment-892746284 https://api.github.com/repos/pydata/xarray/issues/4863 IC_kwDOAMm_X841Njos keewis 14808389 2021-08-04T15:17:51Z 2021-08-04T15:17:51Z MEMBER

that name is temporary, which means it is only visible within the user function. call_on_dataset returns the original name (which I think means the user function shouldn't rename, because that would be silently undone)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
886241928 https://github.com/pydata/xarray/pull/4863#issuecomment-886241928 https://api.github.com/repos/pydata/xarray/issues/4863 IC_kwDOAMm_X8400vqI max-sixty 5635139 2021-07-25T18:43:58Z 2021-07-25T18:43:58Z MEMBER

passing the name makes it cleaner, but we could also add a default value (THIS_ARRAY?).

Yes agree! No strong view on what it should be, THIS_ARRAY seems fine.

Would we remove the name before passing back the array?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
885959659 https://github.com/pydata/xarray/pull/4863#issuecomment-885959659 https://api.github.com/repos/pydata/xarray/issues/4863 IC_kwDOAMm_X840zqvr github-actions[bot] 41898282 2021-07-23T23:25:07Z 2021-07-23T23:25:07Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   53m 52s :stopwatch: 16 203 tests 14 468 :heavy_check_mark: 1 735 :zzz: 0 :x: 90 414 runs  82 238 :heavy_check_mark: 8 176 :zzz: 0 :x:

Results for commit 12400cb7.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
885952834 https://github.com/pydata/xarray/pull/4863#issuecomment-885952834 https://api.github.com/repos/pydata/xarray/issues/4863 IC_kwDOAMm_X840zpFC keewis 14808389 2021-07-23T22:59:13Z 2021-07-23T22:59:13Z MEMBER

IIUC people can do .rename rather than passing a name.

passing the name makes it cleaner, but we could also add a default value (THIS_ARRAY?).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
865280806 https://github.com/pydata/xarray/pull/4863#issuecomment-865280806 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDg2NTI4MDgwNg== max-sixty 5635139 2021-06-21T19:14:51Z 2021-06-21T19:14:51Z MEMBER

upon further consideration, I think we have the choice between using a generic name, raising for unnamed DataArray objects or adding a name parameter, with a default to None / the THIS_ARRAY object which would be similar to saying "I don't care about the name" (and either always use that name or only for unnamed DataArray objects).

I think I would prefer option 3a (always use the passed name, even if the DataArray already had a name).

IIUC people can do .rename rather than passing a name. Unless I'm missing something I would lightly vote to remove that arg.

But no strong preference and +1 to merging this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
817134098 https://github.com/pydata/xarray/pull/4863#issuecomment-817134098 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDgxNzEzNDA5OA== keewis 14808389 2021-04-10T13:07:13Z 2021-04-10T13:08:05Z MEMBER

upon further consideration, I think we have the choice between using a generic name, raising for unnamed DataArray objects or adding a name parameter, with a default to None / the THIS_ARRAY object which would be similar to saying "I don't care about the name" (and either always use that name or only for unnamed DataArray objects).

I think I would prefer option 3a (always use the passed name, even if the DataArray already had a name).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
799804272 https://github.com/pydata/xarray/pull/4863#issuecomment-799804272 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc5OTgwNDI3Mg== max-sixty 5635139 2021-03-15T22:44:22Z 2021-03-15T22:44:22Z MEMBER

Looks great!

(no view on sentinel vs string though)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
799663264 https://github.com/pydata/xarray/pull/4863#issuecomment-799663264 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc5OTY2MzI2NA== keewis 14808389 2021-03-15T18:44:19Z 2021-03-15T18:44:19Z MEMBER

I switched to dataarray_to_dataset instead of _to_temp_dataset. However, it might be important to be able to reference the data variable by name, which leaves us two choices: move _THIS_ARRAY to the public namespace or rename to a string. I chose the latter (not sure if there's a better choice) and modified the notes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
797044716 https://github.com/pydata/xarray/pull/4863#issuecomment-797044716 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc5NzA0NDcxNg== max-sixty 5635139 2021-03-11T20:59:10Z 2021-03-11T20:59:10Z MEMBER

call_on_dataset, maybe?

I like that!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
797034254 https://github.com/pydata/xarray/pull/4863#issuecomment-797034254 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc5NzAzNDI1NA== keewis 14808389 2021-03-11T20:40:21Z 2021-03-11T20:40:21Z MEMBER

call_on_dataset, maybe?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
796924864 https://github.com/pydata/xarray/pull/4863#issuecomment-796924864 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc5NjkyNDg2NA== max-sixty 5635139 2021-03-11T17:54:04Z 2021-03-11T17:54:04Z MEMBER

I reckon this is ready to merge!

One final pause on the name — apply isn't used in python much — would something with call work? But call_as_dataset sounds like we're call-ing a dataset rather than a function. call_with_dataset?. Unless anyone has any bright ideas, I think this is great as-is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
773752412 https://github.com/pydata/xarray/pull/4863#issuecomment-773752412 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc3Mzc1MjQxMg== max-sixty 5635139 2021-02-05T03:05:03Z 2021-02-05T03:05:03Z MEMBER

I think this is great!

I agree the name doesn't sing, but also I can't think of a better one...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
773688928 https://github.com/pydata/xarray/pull/4863#issuecomment-773688928 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc3MzY4ODkyOA== keewis 14808389 2021-02-05T00:14:33Z 2021-02-05T00:14:33Z MEMBER

sure, although I would use xr.apply_as_dataset(func_that_expects_datasets, dataset_or_dataarray, *args, **kwargs)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730
773687947 https://github.com/pydata/xarray/pull/4863#issuecomment-773687947 https://api.github.com/repos/pydata/xarray/issues/4863 MDEyOklzc3VlQ29tbWVudDc3MzY4Nzk0Nw== dcherian 2448579 2021-02-05T00:11:58Z 2021-02-05T00:11:58Z MEMBER

Should this be a top-level

xr.apply_as_dataset(func_that_expects_datasets, dataset_or_dataarray, args=None, kwargs=None)

instead?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply to dataset 801728730

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);