issue_comments: 865280806

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4863#issuecomment-865280806 https://api.github.com/repos/pydata/xarray/issues/4863 865280806 MDEyOklzc3VlQ29tbWVudDg2NTI4MDgwNg== 5635139 2021-06-21T19:14:51Z 2021-06-21T19:14:51Z MEMBER

upon further consideration, I think we have the choice between using a generic name, raising for unnamed DataArray objects or adding a name parameter, with a default to None / the THIS_ARRAY object which would be similar to saying "I don't care about the name" (and either always use that name or only for unnamed DataArray objects).

I think I would prefer option 3a (always use the passed name, even if the DataArray already had a name).

IIUC people can do .rename rather than passing a name. Unless I'm missing something I would lightly vote to remove that arg.

But no strong preference and +1 to merging this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   801728730