issue_comments

Table actions

4 rows where issue = 798592803 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • cftime default's datetime breaks CFTimeIndex · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
774219889 https://github.com/pydata/xarray/issues/4853#issuecomment-774219889 https://api.github.com/repos/pydata/xarray/issues/4853 MDEyOklzc3VlQ29tbWVudDc3NDIxOTg4OQ== spencerkclark 6628425 2021-02-05T18:48:31Z 2021-02-05T18:48:31Z MEMBER

Actually @jswhit already made the release (sorry I missed this!), so this is fixed upstream. I'll leave this issue open, however, since I think it would be good to make CFTimeIndex compatible with cftime's new universal datetime object.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cftime default's datetime breaks CFTimeIndex 798592803
773259514 https://github.com/pydata/xarray/issues/4853#issuecomment-773259514 https://api.github.com/repos/pydata/xarray/issues/4853 MDEyOklzc3VlQ29tbWVudDc3MzI1OTUxNA== spencerkclark 6628425 2021-02-04T12:08:12Z 2021-02-04T12:08:12Z MEMBER

This behavior will be rolled back in the next release of cftime, which @jswhit said he would issue soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cftime default's datetime breaks CFTimeIndex 798592803
771145053 https://github.com/pydata/xarray/issues/4853#issuecomment-771145053 https://api.github.com/repos/pydata/xarray/issues/4853 MDEyOklzc3VlQ29tbWVudDc3MTE0NTA1Mw== spencerkclark 6628425 2021-02-01T20:43:30Z 2021-02-01T21:03:01Z MEMBER

Yikes, indeed I was concerned about that when you first posted the issue. In hindsight it's pretty clear why this causes problems within CFTimeIndex; as you note, we rely on passing the date_type around in a variety of places, and with the new change this means the calendar type is lost. I carelessly took the xarray test suite passing as reason to believe everything would be OK.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cftime default's datetime breaks CFTimeIndex 798592803
771120951 https://github.com/pydata/xarray/issues/4853#issuecomment-771120951 https://api.github.com/repos/pydata/xarray/issues/4853 MDEyOklzc3VlQ29tbWVudDc3MTEyMDk1MQ== aulemahal 20629530 2021-02-01T20:03:04Z 2021-02-01T20:03:04Z CONTRIBUTOR

Woups, the bug seems more important than I first thought. It happens when reading files: MWE: ```python import xarray as xr

da = xr.DataArray( [0, 1, 2], dims=('time',), coords={'time': xr.cftime_range('2000-01-01', freq='D', periods=3, calendar='noleap')}, name='test' ) da.to_netcdf('test.nc')

da2 = xr.open_dataset('test.nc') da2.indexes['time'] Fails with an error similar to the example above. Also failing on :python da2.sel(time='2000') ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cftime default's datetime breaks CFTimeIndex 798592803

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);