issue_comments: 771145053

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4853#issuecomment-771145053 https://api.github.com/repos/pydata/xarray/issues/4853 771145053 MDEyOklzc3VlQ29tbWVudDc3MTE0NTA1Mw== 6628425 2021-02-01T20:43:30Z 2021-02-01T21:03:01Z MEMBER

Yikes, indeed I was concerned about that when you first posted the issue. In hindsight it's pretty clear why this causes problems within CFTimeIndex; as you note, we rely on passing the date_type around in a variety of places, and with the new change this means the calendar type is lost. I carelessly took the xarray test suite passing as reason to believe everything would be OK.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   798592803