issue_comments

Table actions

3 rows where issue = 788534915 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • dcherian · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
840687993 https://github.com/pydata/xarray/issues/4824#issuecomment-840687993 https://api.github.com/repos/pydata/xarray/issues/4824 MDEyOklzc3VlQ29tbWVudDg0MDY4Nzk5Mw== dcherian 2448579 2021-05-13T16:47:56Z 2021-05-13T16:47:56Z MEMBER

Does that mean we should just not to allow join='override' for combine_by_coords?

I think so.

I suspect the original problem can only be solved by allowing approximate alignment within a specified tolerance.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords can succed when it shouldn't 788534915
840675463 https://github.com/pydata/xarray/issues/4824#issuecomment-840675463 https://api.github.com/repos/pydata/xarray/issues/4824 MDEyOklzc3VlQ29tbWVudDg0MDY3NTQ2Mw== dcherian 2448579 2021-05-13T16:27:15Z 2021-05-13T16:27:38Z MEMBER

For concat, join applies to all indexes that are not being concatenated (e.g. concat over time but override floating point differences in latitude). This is easy to understand for combine_nested.

I don't think it makes sense at all for combine_by_coords. If you want to override coordinate labels values for some dimensions you should have to do it manually. It seems easy to land up in weird edge-cases when you combine that with autoguessing behaviour.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords can succed when it shouldn't 788534915
771684107 https://github.com/pydata/xarray/issues/4824#issuecomment-771684107 https://api.github.com/repos/pydata/xarray/issues/4824 MDEyOklzc3VlQ29tbWVudDc3MTY4NDEwNw== dcherian 2448579 2021-02-02T14:44:45Z 2021-02-02T14:45:04Z MEMBER

this is the result of join="outer" which expands both datasets, and compat="no_conflicts" which picks the not-NaN value. These are both default values.

You can avoid this by setting join="override" which will skip the check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords can succed when it shouldn't 788534915

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);