issue_comments

Table actions

12 rows where issue = 788398518 and user = 6042212 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • martindurant · 12 ✖

issue 1

  • Allow fsspec URLs in open_(mf)dataset · 12 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
780127931 https://github.com/pydata/xarray/pull/4823#issuecomment-780127931 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc4MDEyNzkzMQ== martindurant 6042212 2021-02-16T21:26:52Z 2021-02-16T21:26:52Z CONTRIBUTOR

Thank you, @dcherian 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
779870336 https://github.com/pydata/xarray/pull/4823#issuecomment-779870336 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc3OTg3MDMzNg== martindurant 6042212 2021-02-16T14:26:12Z 2021-02-16T14:26:12Z CONTRIBUTOR

Can someone please explain the minimum version policy that is failing ``` Package Required Policy Status

aiobotocore 1.1.2 (2020-08-18) 0.12 (2020-02-24) > (!) (w) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
778353067 https://github.com/pydata/xarray/pull/4823#issuecomment-778353067 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc3ODM1MzA2Nw== martindurant 6042212 2021-02-12T18:06:49Z 2021-02-12T18:06:49Z CONTRIBUTOR

@raybellwaves , might I paraphrase to "this PR is useful, please merge!" ?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
769247752 https://github.com/pydata/xarray/pull/4823#issuecomment-769247752 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2OTI0Nzc1Mg== martindurant 6042212 2021-01-28T17:27:50Z 2021-01-28T17:27:50Z CONTRIBUTOR

I have decided, on reflection, to back away on the scope here and only implement for zarr for now, since, frankly, I am confused about what should happen for other backends, and they are not tested. Yes, some of them are happy to accept file-like objects, but others either don't do that at all, or want the URL passing through. My code would have changed how things were handled, depending on whether it passed through open_dataset or open_mfdataset. Best would be to set up a set of expectations as tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
768393609 https://github.com/pydata/xarray/pull/4823#issuecomment-768393609 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2ODM5MzYwOQ== martindurant 6042212 2021-01-27T16:10:39Z 2021-01-27T16:10:39Z CONTRIBUTOR

Thanks, @kmuehlbauer 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
768385226 https://github.com/pydata/xarray/pull/4823#issuecomment-768385226 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2ODM4NTIyNg== martindurant 6042212 2021-01-27T15:58:15Z 2021-01-27T15:58:15Z CONTRIBUTOR

The RTD failure appears to be: WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory 'https://scitools.org.uk/iris/docs/latest/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: Not Found for url: https://scitools.org.uk/iris/docs/latest/objects.inv which, I'm afraid, doesn't mean much to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
768362931 https://github.com/pydata/xarray/pull/4823#issuecomment-768362931 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2ODM2MjkzMQ== martindurant 6042212 2021-01-27T15:26:57Z 2021-01-27T15:26:57Z CONTRIBUTOR

I am marking this PR as ready, but please ask me for specific test cases that might be relevant and should be included.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
764649377 https://github.com/pydata/xarray/pull/4823#issuecomment-764649377 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2NDY0OTM3Nw== martindurant 6042212 2021-01-21T13:40:33Z 2021-01-21T13:40:33Z CONTRIBUTOR

(please definitely do not merge until I've added documentation)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
762858956 https://github.com/pydata/xarray/pull/4823#issuecomment-762858956 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2Mjg1ODk1Ng== martindurant 6042212 2021-01-19T14:04:05Z 2021-01-19T14:04:05Z CONTRIBUTOR

Next open question: aside from zarr, few of the other backends will know what to do with fsspec's dict-like mappers. Should we prevent them from passing through? Should we attempt to distinguish between directories and files, and make fsspec file-like objects? We could just allow the backends to fail later on incorrect input.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
762394713 https://github.com/pydata/xarray/pull/4823#issuecomment-762394713 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2MjM5NDcxMw== martindurant 6042212 2021-01-18T17:52:47Z 2021-01-18T17:55:19Z CONTRIBUTOR

pint errors in xarray/tests/test_units.py::TestVariable appear unrelated

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
762367350 https://github.com/pydata/xarray/pull/4823#issuecomment-762367350 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2MjM2NzM1MA== martindurant 6042212 2021-01-18T16:54:21Z 2021-01-18T16:54:21Z CONTRIBUTOR

Question: should HTTP URLs be passed through unprocessed as before? I think that might be required by some of the netCDF engines, but we probably don't test this. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518
762350678 https://github.com/pydata/xarray/pull/4823#issuecomment-762350678 https://api.github.com/repos/pydata/xarray/issues/4823 MDEyOklzc3VlQ29tbWVudDc2MjM1MDY3OA== martindurant 6042212 2021-01-18T16:22:53Z 2021-01-18T16:22:53Z CONTRIBUTOR

Docs to be added

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow fsspec URLs in open_(mf)dataset 788398518

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);