home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 769247752

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4823#issuecomment-769247752 https://api.github.com/repos/pydata/xarray/issues/4823 769247752 MDEyOklzc3VlQ29tbWVudDc2OTI0Nzc1Mg== 6042212 2021-01-28T17:27:50Z 2021-01-28T17:27:50Z CONTRIBUTOR

I have decided, on reflection, to back away on the scope here and only implement for zarr for now, since, frankly, I am confused about what should happen for other backends, and they are not tested. Yes, some of them are happy to accept file-like objects, but others either don't do that at all, or want the URL passing through. My code would have changed how things were handled, depending on whether it passed through open_dataset or open_mfdataset. Best would be to set up a set of expectations as tests.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  788398518
Powered by Datasette · Queries took 1.608ms · About: xarray-datasette