issue_comments

Table actions

5 rows where issue = 773750763 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • xr.testing.assert_equal does not test for dtype · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
751843789 https://github.com/pydata/xarray/issues/4727#issuecomment-751843789 https://api.github.com/repos/pydata/xarray/issues/4727 MDEyOklzc3VlQ29tbWVudDc1MTg0Mzc4OQ== max-sixty 5635139 2020-12-28T19:50:17Z 2020-12-28T19:50:17Z MEMBER

I agree with @toddrjen that the words of assert_identical strongly suggest that the dtypes would be checked.

I would suggest we either: - Fail on different dtypes in 0.17 - If there are lots of breaks / downstream libraries that may break: add a FutureWarning on different dtypes and change in the future

Happy to help on this!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.testing.assert_equal does not test for dtype 773750763
750926206 https://github.com/pydata/xarray/issues/4727#issuecomment-750926206 https://api.github.com/repos/pydata/xarray/issues/4727 MDEyOklzc3VlQ29tbWVudDc1MDkyNjIwNg== mathause 10194086 2020-12-24T16:51:42Z 2020-12-24T19:28:23Z MEMBER

There seems to be a subtle difference between comparing Dataset and DataArray.

DataArray compares coords:

https://github.com/pydata/xarray/blob/03d8d56c9b6d090f0de2475202368b08435eaeb5/xarray/core/dataarray.py#L2792

while Dataset compares _variables:

https://github.com/pydata/xarray/blob/03d8d56c9b6d090f0de2475202368b08435eaeb5/xarray/core/dataset.py#L1457-L1459

Thus once we compare xarray.core.variable.IndexVariable and once we compare xarray.core.dataarray.DataArray and the comparison takes different code paths...

```python import xarray as xr air = xr.tutorial.open_dataset("air_temperature")

type(air._variables["lat"])

xarray.core.variable.IndexVariable

type(air.air.coords["lat"])

xarray.core.dataarray.DataArray

```

edit: typo

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.testing.assert_equal does not test for dtype 773750763
750419141 https://github.com/pydata/xarray/issues/4727#issuecomment-750419141 https://api.github.com/repos/pydata/xarray/issues/4727 MDEyOklzc3VlQ29tbWVudDc1MDQxOTE0MQ== toddrjen 2272878 2020-12-23T18:23:20Z 2020-12-23T18:23:20Z CONTRIBUTOR

My concern with assert_identical is the name. It implies, to me, that there is no difference at all between the two objects. It was highly unexpected for me that it didn't do that. I think at the very least it should be clarified in the documentation that it doesn't do that.

If the default for assert_identical isn't change, I wonder whether a new function might be worthwhile. I am concerned having to append check_dtype=True for every test would hurt test clarity. And there is also the problem with

Also, just checking dtype won't be sufficient in all cases. Consider this:

```Python import numpy as np import xarray as xr

a = xr.DataArray(np.array(1.0, dtype=np.object))
b = xr.DataArray(np.array(1, dtype=np.object))

xr.testing.assert_identical(a, b)
```

I think for the purpose of testing being able to make sure the result is exactly what you expect is important.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.testing.assert_equal does not test for dtype 773750763
750386723 https://github.com/pydata/xarray/issues/4727#issuecomment-750386723 https://api.github.com/repos/pydata/xarray/issues/4727 MDEyOklzc3VlQ29tbWVudDc1MDM4NjcyMw== keewis 14808389 2020-12-23T16:56:11Z 2020-12-23T17:04:12Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.testing.assert_equal does not test for dtype 773750763
750354606 https://github.com/pydata/xarray/issues/4727#issuecomment-750354606 https://api.github.com/repos/pydata/xarray/issues/4727 MDEyOklzc3VlQ29tbWVudDc1MDM1NDYwNg== dcherian 2448579 2020-12-23T15:40:07Z 2020-12-23T15:40:07Z MEMBER

+1 on adding check_dtype. I think it should be default False for assert_equal.

It could be default True for assert_identical but this would be very backward incompatible.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.testing.assert_equal does not test for dtype 773750763

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);