home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 751843789

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4727#issuecomment-751843789 https://api.github.com/repos/pydata/xarray/issues/4727 751843789 MDEyOklzc3VlQ29tbWVudDc1MTg0Mzc4OQ== 5635139 2020-12-28T19:50:17Z 2020-12-28T19:50:17Z MEMBER

I agree with @toddrjen that the words of assert_identical strongly suggest that the dtypes would be checked.

I would suggest we either: - Fail on different dtypes in 0.17 - If there are lots of breaks / downstream libraries that may break: add a FutureWarning on different dtypes and change in the future

Happy to help on this!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  773750763
Powered by Datasette · Queries took 242.581ms · About: xarray-datasette