issue_comments

Table actions

7 rows where issue = 756415834 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • DataArray transpose inconsistent with Dataset Ellipsis usage · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
754717639 https://github.com/pydata/xarray/issues/4647#issuecomment-754717639 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDc1NDcxNzYzOQ== max-sixty 5635139 2021-01-05T15:45:30Z 2021-01-05T15:45:30Z MEMBER

Yes, agree this should be changed in infix_dims.

Fine to update the return type if it changes, but no need to coerce it premptively.

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834
754695667 https://github.com/pydata/xarray/issues/4647#issuecomment-754695667 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDc1NDY5NTY2Nw== mesejo 8579156 2021-01-05T15:10:42Z 2021-01-05T15:10:42Z CONTRIBUTOR

Hey, I was working on this and notice that transpose uses the method infix_dims to resolve the Ellipsis, should I put the expected behavior on infix_dims or only on transpose? The method infix_dims is also used in variable.transpose and in variable._stack_once. For me it seems right to put the new behavior on infix_dims to keep the behavior uniform, but I would like to know your opinion.

As a side-note I also noted that the return value of infix_dims is an iterator but on every usage is either converted to tuple or list, should I change the return value or keep it as it is?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834
753477348 https://github.com/pydata/xarray/issues/4647#issuecomment-753477348 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDc1MzQ3NzM0OA== ahuang11 15331990 2021-01-02T14:01:49Z 2021-01-02T14:01:49Z CONTRIBUTOR

Sure.

On Sat, Jan 2, 2021, 6:38 AM Daniel Mesejo-León notifications@github.com wrote:

Hey! Can I work on this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/4647#issuecomment-753468760, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU7FFVUS2TTAA6MRGX5G73SX4HSRANCNFSM4UMKLBWQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834
753468760 https://github.com/pydata/xarray/issues/4647#issuecomment-753468760 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDc1MzQ2ODc2MA== mesejo 8579156 2021-01-02T12:37:49Z 2021-01-02T12:37:49Z CONTRIBUTOR

Hey! Can I work on this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834
740209272 https://github.com/pydata/xarray/issues/4647#issuecomment-740209272 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDc0MDIwOTI3Mg== dcherian 2448579 2020-12-07T22:07:26Z 2020-12-07T22:07:26Z MEMBER

Yes i think missing_dims="ignore" would be great. This would match the kwarg in isel (https://xarray.pydata.org/en/stable/generated/xarray.Dataset.isel.html)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834
738187109 https://github.com/pydata/xarray/issues/4647#issuecomment-738187109 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDczODE4NzEwOQ== ahuang11 15331990 2020-12-03T18:10:44Z 2020-12-03T18:10:44Z CONTRIBUTOR

ds.transpose('not_existing_dim', 'lat', 'lon', 'time', ...)

IMO this should raise an error too

I actually like it handling non_existing_dims automatically; maybe could be keyword though: ds.transpose('not_existing_dim', 'lat', 'lon', 'time', ..., errors='ignore')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834
738185880 https://github.com/pydata/xarray/issues/4647#issuecomment-738185880 https://api.github.com/repos/pydata/xarray/issues/4647 MDEyOklzc3VlQ29tbWVudDczODE4NTg4MA== dcherian 2448579 2020-12-03T18:08:26Z 2020-12-03T18:08:26Z MEMBER

ds.transpose('not_existing_dim', 'lat', 'lon', 'time', ...)

IMO this should raise an error too

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray transpose inconsistent with Dataset Ellipsis usage 756415834

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);