home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 754695667

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4647#issuecomment-754695667 https://api.github.com/repos/pydata/xarray/issues/4647 754695667 MDEyOklzc3VlQ29tbWVudDc1NDY5NTY2Nw== 8579156 2021-01-05T15:10:42Z 2021-01-05T15:10:42Z CONTRIBUTOR

Hey, I was working on this and notice that transpose uses the method infix_dims to resolve the Ellipsis, should I put the expected behavior on infix_dims or only on transpose? The method infix_dims is also used in variable.transpose and in variable._stack_once. For me it seems right to put the new behavior on infix_dims to keep the behavior uniform, but I would like to know your opinion.

As a side-note I also noted that the return value of infix_dims is an iterator but on every usage is either converted to tuple or list, should I change the return value or keep it as it is?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  756415834
Powered by Datasette · Queries took 0.753ms · About: xarray-datasette