issue_comments

Table actions

5 rows where issue = 755626157 and user = 17162724 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • raybellwaves · 5 ✖

issue 1

  • DOC: add examples to concat · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
745343820 https://github.com/pydata/xarray/pull/4645#issuecomment-745343820 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NTM0MzgyMA== raybellwaves 17162724 2020-12-15T14:53:09Z 2020-12-15T14:53:09Z CONTRIBUTOR

Not sure if I can do anything for the doctest failing https://dev.azure.com/xarray/xarray/_build/results?buildId=4491&view=logs&j=e1da92ae-4a54-5c20-3ee1-ef7b06ffcd80&t=5640f7da-bb07-517b-ec85-0b3cfe0ccaa3&l=62 - * y (y) int32 10 20 30 + * y (y) int64 10 20 30 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157
744708979 https://github.com/pydata/xarray/pull/4645#issuecomment-744708979 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NDcwODk3OQ== raybellwaves 17162724 2020-12-14T21:03:23Z 2020-12-14T21:03:23Z CONTRIBUTOR

I can add to the Whats-new. Not sure how to "update of the doctest output"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157
744662895 https://github.com/pydata/xarray/pull/4645#issuecomment-744662895 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NDY2Mjg5NQ== raybellwaves 17162724 2020-12-14T19:34:48Z 2020-12-14T19:34:48Z CONTRIBUTOR

More than welcome to push to mine.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157
744504122 https://github.com/pydata/xarray/pull/4645#issuecomment-744504122 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NDUwNDEyMg== raybellwaves 17162724 2020-12-14T15:09:41Z 2020-12-14T15:09:41Z CONTRIBUTOR

I would also run pre-commit run --files doc/combining.rst xarray/core/concat.py once, but that's optional.

I'm doing this PR in my windows machine unfortunately, and pre-commit is a pain on windows. Hopefully it's fine as is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157
737616528 https://github.com/pydata/xarray/pull/4645#issuecomment-737616528 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDczNzYxNjUyOA== raybellwaves 17162724 2020-12-03T02:16:43Z 2020-12-03T02:16:43Z CONTRIBUTOR

Thanks for the feedback.

It was a copy-paste from http://xarray.pydata.org/en/stable/combining.html#concatenate

I'll implement your suggestions in https://github.com/pydata/xarray/blob/master/doc/combining.rst as well.

i.e. use arange for the creation and isel for the index.

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);