issue_comments

Thanks @raybellwaves!

Hello @raybellwaves! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-12-19 21:37:51 UTC

I think you replace all int32 by int64?

Not sure if I can do anything for the doctest failing https://dev.azure.com/xarray/xarray/_build/results?buildId=4491&view=logs&j=e1da92ae-4a54-5c20-3ee1-ef7b06ffcd80&t=5640f7da-bb07-517b-ec85-0b3cfe0ccaa3&l=62 - * y (y) int32 10 20 30 + * y (y) int64 10 20 30

sorry about that. I meant that the code examples still show the results using the randomly generated data, and this is the reason why the doctests CI fails.

For example, this: https://github.com/pydata/xarray/blob/4c8642560679c173c2968a2c4186a474bfe97f2d/xarray/core/concat.py#L178-L185 should be: ```python >>> xr.concat([da.isel(y=slice(0, 1)), da.isel(y=slice(1, None))], dim="y") <xarray.DataArray (x: 2, y: 3)> array([[0, 1, 2], [3, 4, 5]]) Coordinates: * x (x) <U1 'a' 'b' * y (y) int64 10 20 30

```

done. Once you update the doctest output and maybe add a entry to whats-new.rst (Documentation) this should be ready for merging.

I can add to the Whats-new. Not sure how to "update of the doctest output"

More than welcome to push to mine.

Hopefully it's fine as is.

no worries, as I said that's optional, we currently don't enforce the tool I had in mind for PRs. I can fix that in a different PR (or this one, if you don't mind me pushing to your branch).

I would also run pre-commit run --files doc/combining.rst xarray/core/concat.py once, but that's optional.

I'm doing this PR in my windows machine unfortunately, and pre-commit is a pain on windows. Hopefully it's fine as is.

Oops one more

```

---

Exception in /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4645/doc/combining.rst at block ending on line 191 Specify :okexcept: as an option in the ipython:: block to suppress this message

NameError Traceback (most recent call last) <ipython-input-25-4cb6d79e0bd5> in <module> ----> 1 arr.equals(arr.copy())

NameError: name 'arr' is not defined <<<------------------------------------------------------------------------- ```

Thanks @raybellwaves. Can you address this error?

```

---

Exception in /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4645/doc/combining.rst at block ending on line 121 Specify :okexcept: as an option in the ipython:: block to suppress this message

NameError Traceback (most recent call last) <ipython-input-16-6d6353d21b81> in <module> ----> 1 xr.Dataset({"a": arr[:-1], "b": arr[1:]})

NameError: name 'arr' is not defined <<<------------------------------------------------------------------------- ```

Thanks for the feedback.

It was a copy-paste from http://xarray.pydata.org/en/stable/combining.html#concatenate

I'll implement your suggestions in https://github.com/pydata/xarray/blob/master/doc/combining.rst as well.

i.e. use arange for the creation and isel for the index.