issue_comments

Table actions

3 rows where issue = 755626157 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 3 ✖

issue 1

  • DOC: add examples to concat · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
744712191 https://github.com/pydata/xarray/pull/4645#issuecomment-744712191 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NDcxMjE5MQ== keewis 14808389 2020-12-14T21:09:49Z 2020-12-14T21:11:51Z MEMBER

sorry about that. I meant that the code examples still show the results using the randomly generated data, and this is the reason why the doctests CI fails.

For example, this: https://github.com/pydata/xarray/blob/4c8642560679c173c2968a2c4186a474bfe97f2d/xarray/core/concat.py#L178-L185 should be: ```python >>> xr.concat([da.isel(y=slice(0, 1)), da.isel(y=slice(1, None))], dim="y") <xarray.DataArray (x: 2, y: 3)> array([[0, 1, 2], [3, 4, 5]]) Coordinates: * x (x) <U1 'a' 'b' * y (y) int64 10 20 30

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157
744668938 https://github.com/pydata/xarray/pull/4645#issuecomment-744668938 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NDY2ODkzOA== keewis 14808389 2020-12-14T19:46:32Z 2020-12-14T21:04:09Z MEMBER

done. Once you update the doctest output and maybe add a entry to whats-new.rst (Documentation) this should be ready for merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157
744661142 https://github.com/pydata/xarray/pull/4645#issuecomment-744661142 https://api.github.com/repos/pydata/xarray/issues/4645 MDEyOklzc3VlQ29tbWVudDc0NDY2MTE0Mg== keewis 14808389 2020-12-14T19:31:32Z 2020-12-14T19:32:12Z MEMBER

Hopefully it's fine as is.

no worries, as I said that's optional, we currently don't enforce the tool I had in mind for PRs. I can fix that in a different PR (or this one, if you don't mind me pushing to your branch).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: add examples to concat 755626157

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);