issue_comments

Table actions

4 rows where issue = 752870062 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • don't type check __getattr__ · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
945827735 https://github.com/pydata/xarray/pull/4616#issuecomment-945827735 https://api.github.com/repos/pydata/xarray/issues/4616 IC_kwDOAMm_X844YC-X mathause 10194086 2021-10-18T14:24:10Z 2021-10-18T14:24:10Z MEMBER

I closed the PR by accident - no strong opinion whether to re-open it. Would be nice to get it in, but this can only be done once all the injected methods are replaced & I currently don't have time to work on this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't type check __getattr__ 752870062
736323145 https://github.com/pydata/xarray/pull/4616#issuecomment-736323145 https://api.github.com/repos/pydata/xarray/issues/4616 MDEyOklzc3VlQ29tbWVudDczNjMyMzE0NQ== mathause 10194086 2020-12-01T08:56:22Z 2020-12-01T08:56:22Z MEMBER

Yes, I think that would be worthwhile. Not necessarily because of static typing but because it's quite difficult to understand. There is also a TODO on that:

https://github.com/pydata/xarray/blob/180e76d106c697b1dd94b814a49dc2d7e58c8551/xarray/core/ops.py#L3-L5

I think it should not be too difficult to create a Mixin class. Maybe the docstrings could still be injected. Not sure what is meant with xarray.core.computation (apply_ufunc?) and how the __array_ufunc__ part would work.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't type check __getattr__ 752870062
736291662 https://github.com/pydata/xarray/pull/4616#issuecomment-736291662 https://api.github.com/repos/pydata/xarray/issues/4616 MDEyOklzc3VlQ29tbWVudDczNjI5MTY2Mg== max-sixty 5635139 2020-12-01T07:54:19Z 2020-12-01T07:54:19Z MEMBER

In a way we have two mistakes cancelling each other out — missing methods and not type checking any method because of __getattr__.

We could attempt to add in the methods explicitly rather than injecting them dynamically. I had thoughts about writing something to generate the python code & docstrings, which would give us the benefits of having them statically without the toil of writing them all out / keeping docstrings up to date, but not sure it would save enough time to make it worthwhile.

Any other ideas / thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't type check __getattr__ 752870062
735674308 https://github.com/pydata/xarray/pull/4616#issuecomment-735674308 https://api.github.com/repos/pydata/xarray/issues/4616 MDEyOklzc3VlQ29tbWVudDczNTY3NDMwOA== mathause 10194086 2020-11-30T09:43:24Z 2020-11-30T09:43:24Z MEMBER

Does this mean that any library downstream that runs notnull will get a type error?

Yes you are right - I haven't thought this through! This does not only apply for notnull but also for mean etc. because all these operations are injected. So this is definitely a blocker.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't type check __getattr__ 752870062

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);