home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 736291662

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4616#issuecomment-736291662 https://api.github.com/repos/pydata/xarray/issues/4616 736291662 MDEyOklzc3VlQ29tbWVudDczNjI5MTY2Mg== 5635139 2020-12-01T07:54:19Z 2020-12-01T07:54:19Z MEMBER

In a way we have two mistakes cancelling each other out — missing methods and not type checking any method because of __getattr__.

We could attempt to add in the methods explicitly rather than injecting them dynamically. I had thoughts about writing something to generate the python code & docstrings, which would give us the benefits of having them statically without the toil of writing them all out / keeping docstrings up to date, but not sure it would save enough time to make it worthwhile.

Any other ideas / thoughts?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  752870062
Powered by Datasette · Queries took 0.688ms · About: xarray-datasette