issue_comments

Table actions

2 rows where issue = 748094631 and user = 6628425 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • spencerkclark · 2 ✖

issue 1

  • add freq as CFTimeIndex property and to CFTimeIndex.__repr__ · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
731646114 https://github.com/pydata/xarray/pull/4597#issuecomment-731646114 https://api.github.com/repos/pydata/xarray/issues/4597 MDEyOklzc3VlQ29tbWVudDczMTY0NjExNA== spencerkclark 6628425 2020-11-21T22:27:34Z 2020-11-21T22:46:08Z MEMBER

Thanks @keewis I didn't realize this was also happening in CI. Yeah, the version is definitely the problem: cftime 1.0.4.2 py36hc1659b7_0 conda-forge My vote for now would be to skip these tests on versions less than 1.1.0. Perhaps we could also think about adding a nicer error message if the version is not up-to-date enough.

~~I guess our test coverage of infer_freq wasn't good enough to trip this up already.~~ Oops we already have a precedent of skipping the infer_freq tests that require this, e.g.: https://github.com/pydata/xarray/blob/a2192158e3fbb94b2d972ff3e1693fffa65e50be/xarray/tests/test_cftimeindex.py#L1180-L1192

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add freq as CFTimeIndex property and to CFTimeIndex.__repr__ 748094631
731645114 https://github.com/pydata/xarray/pull/4597#issuecomment-731645114 https://api.github.com/repos/pydata/xarray/issues/4597 MDEyOklzc3VlQ29tbWVudDczMTY0NTExNA== spencerkclark 6628425 2020-11-21T22:19:12Z 2020-11-21T22:19:12Z MEMBER

freq would be consistent with pandas: ``` In [1]: import pandas as pd

In [2]: pd.date_range("2000", periods=3) Out[2]: DatetimeIndex(['2000-01-01', '2000-01-02', '2000-01-03'], dtype='datetime64[ns]', freq='D') ```

@aaronspring regarding the local test failure -- which version of cftime are you using in your environment? The daysinmonth attribute did not always exist; it was added in version 1.1.0. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add freq as CFTimeIndex property and to CFTimeIndex.__repr__ 748094631

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);