home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 731646114

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4597#issuecomment-731646114 https://api.github.com/repos/pydata/xarray/issues/4597 731646114 MDEyOklzc3VlQ29tbWVudDczMTY0NjExNA== 6628425 2020-11-21T22:27:34Z 2020-11-21T22:46:08Z MEMBER

Thanks @keewis I didn't realize this was also happening in CI. Yeah, the version is definitely the problem: cftime 1.0.4.2 py36hc1659b7_0 conda-forge My vote for now would be to skip these tests on versions less than 1.1.0. Perhaps we could also think about adding a nicer error message if the version is not up-to-date enough.

~~I guess our test coverage of infer_freq wasn't good enough to trip this up already.~~ Oops we already have a precedent of skipping the infer_freq tests that require this, e.g.: https://github.com/pydata/xarray/blob/a2192158e3fbb94b2d972ff3e1693fffa65e50be/xarray/tests/test_cftimeindex.py#L1180-L1192

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  748094631
Powered by Datasette · Queries took 0.457ms · About: xarray-datasette