issue_comments

Table actions

6 rows where issue = 721853828 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • rolling keep_attrs & default True · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
724216787 https://github.com/pydata/xarray/pull/4510#issuecomment-724216787 https://api.github.com/repos/pydata/xarray/issues/4510 MDEyOklzc3VlQ29tbWVudDcyNDIxNjc4Nw== max-sixty 5635139 2020-11-09T19:10:23Z 2020-11-09T19:10:23Z MEMBER

Thanks again @mathause ! 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling keep_attrs & default True 721853828
719538691 https://github.com/pydata/xarray/pull/4510#issuecomment-719538691 https://api.github.com/repos/pydata/xarray/issues/4510 MDEyOklzc3VlQ29tbWVudDcxOTUzODY5MQ== mathause 10194086 2020-10-30T13:01:38Z 2020-10-30T13:01:38Z MEMBER

I added a test to ensure da.name is conserved & the tests passed. So this is finished from my side. I guess this is not so easy to review as I change one or two lines per function in a lot of functions. So maybe someone could just review the tests? Or maybe you already did?

While working on this I thought rolling could profit from some refactoring but I kept it out of this PR. I might follow up with do this if I find time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling keep_attrs & default True 721853828
719102410 https://github.com/pydata/xarray/pull/4510#issuecomment-719102410 https://api.github.com/repos/pydata/xarray/issues/4510 MDEyOklzc3VlQ29tbWVudDcxOTEwMjQxMA== max-sixty 5635139 2020-10-30T00:40:56Z 2020-10-30T00:40:56Z MEMBER

Any other thoughts before we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling keep_attrs & default True 721853828
716702055 https://github.com/pydata/xarray/pull/4510#issuecomment-716702055 https://api.github.com/repos/pydata/xarray/issues/4510 MDEyOklzc3VlQ29tbWVudDcxNjcwMjA1NQ== max-sixty 5635139 2020-10-26T17:22:00Z 2020-10-26T17:22:00Z MEMBER

Wow, this was quite the herculean effort @mathause . Thanks. That solves any questions I had about whether the global configs are being honored...

To the extent we have to do more of these, we could consider whether we need to add keep_attrs kwargs, or we should recommend users removing attrs separately where needed. We'd still need to through the global defaults, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling keep_attrs & default True 721853828
709266070 https://github.com/pydata/xarray/pull/4510#issuecomment-709266070 https://api.github.com/repos/pydata/xarray/issues/4510 MDEyOklzc3VlQ29tbWVudDcwOTI2NjA3MA== mathause 10194086 2020-10-15T12:15:29Z 2020-10-15T12:15:29Z MEMBER

As mentioned in #4513 I should probably switch from ds.rolling(..., keep_attrs=True).mean() to ds.rolling(...).mean( keep_attrs=True). Let's see if there is feedback/ a consensus on #4513

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling keep_attrs & default True 721853828
708838377 https://github.com/pydata/xarray/pull/4510#issuecomment-708838377 https://api.github.com/repos/pydata/xarray/issues/4510 MDEyOklzc3VlQ29tbWVudDcwODgzODM3Nw== max-sixty 5635139 2020-10-15T01:31:16Z 2020-10-15T01:31:16Z MEMBER

Great, thanks!

Are the global configs still being honored in rolling? No strong view on whether they should be, though it affects whether we have defaults of None.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling keep_attrs & default True 721853828

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);