home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 719538691

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4510#issuecomment-719538691 https://api.github.com/repos/pydata/xarray/issues/4510 719538691 MDEyOklzc3VlQ29tbWVudDcxOTUzODY5MQ== 10194086 2020-10-30T13:01:38Z 2020-10-30T13:01:38Z MEMBER

I added a test to ensure da.name is conserved & the tests passed. So this is finished from my side. I guess this is not so easy to review as I change one or two lines per function in a lot of functions. So maybe someone could just review the tests? Or maybe you already did?

While working on this I thought rolling could profit from some refactoring but I kept it out of this PR. I might follow up with do this if I find time.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  721853828
Powered by Datasette · Queries took 0.451ms · About: xarray-datasette