issue_comments

Table actions

3 rows where issue = 715168959 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Alignment with tolerance2 · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
831811778 https://github.com/pydata/xarray/pull/4489#issuecomment-831811778 https://api.github.com/repos/pydata/xarray/issues/4489 MDEyOklzc3VlQ29tbWVudDgzMTgxMTc3OA== ghislainp 10563614 2021-05-04T09:37:50Z 2021-05-04T09:37:50Z CONTRIBUTOR

yes, no problem, take your time. This is still a wanted feature in any case, I've recently needed it again. I've found a solution by converting the real index to integer after adequate scaling, but an integrated solution would be much better.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Alignment with tolerance2 715168959
831809607 https://github.com/pydata/xarray/pull/4489#issuecomment-831809607 https://api.github.com/repos/pydata/xarray/issues/4489 MDEyOklzc3VlQ29tbWVudDgzMTgwOTYwNw== benbovy 4160723 2021-05-04T09:33:56Z 2021-05-04T09:33:56Z MEMBER

Sorry for the very long wait @ghislainp.

This looks like a great case for the ongoing flexible indexes refactor (see design notes, #4979). This refactor consists of abstracting away index operations like label-based selection and alignment and delegate them to (built-in or 3rd-party) xarray.Index subclasses.

After the refactoring, I think that what you propose here would nicely fit in PandasIndex (see #5102) if that's a common case, or perhaps better in its own xarray.Index subclass.

Would you mind waiting a bit more for the new flexible index system to be operational before adding this feature? This will make the refactoring easier. Also, we still need to figure out how best to expose index-specific options (like tolerance here, but it could be various options depending on the index) in parts of the xarray API like align, so it might be best if we can avoid breaking changes and/or depreciation cycles as much as possible until then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Alignment with tolerance2 715168959
708517335 https://github.com/pydata/xarray/pull/4489#issuecomment-708517335 https://api.github.com/repos/pydata/xarray/issues/4489 MDEyOklzc3VlQ29tbWVudDcwODUxNzMzNQ== dcherian 2448579 2020-10-14T16:31:02Z 2020-10-14T16:31:02Z MEMBER

Thanks @ghislainp . This is a substantial change, so it may take some time for one of us to look through it. Thank you for your patience.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Alignment with tolerance2 715168959

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);