issue_comments: 831809607

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4489#issuecomment-831809607 https://api.github.com/repos/pydata/xarray/issues/4489 831809607 MDEyOklzc3VlQ29tbWVudDgzMTgwOTYwNw== 4160723 2021-05-04T09:33:56Z 2021-05-04T09:33:56Z MEMBER

Sorry for the very long wait @ghislainp.

This looks like a great case for the ongoing flexible indexes refactor (see design notes, #4979). This refactor consists of abstracting away index operations like label-based selection and alignment and delegate them to (built-in or 3rd-party) xarray.Index subclasses.

After the refactoring, I think that what you propose here would nicely fit in PandasIndex (see #5102) if that's a common case, or perhaps better in its own xarray.Index subclass.

Would you mind waiting a bit more for the new flexible index system to be operational before adding this feature? This will make the refactoring easier. Also, we still need to figure out how best to expose index-specific options (like tolerance here, but it could be various options depending on the index) in parts of the xarray API like align, so it might be best if we can avoid breaking changes and/or depreciation cycles as much as possible until then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   715168959