issue_comments

Table actions

3 rows where issue = 70805273 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • jhamman · 3 ✖

issue 1

  • Handle bool in NetCDF4 conversion · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
219188897 https://github.com/pydata/xarray/pull/401#issuecomment-219188897 https://api.github.com/repos/pydata/xarray/issues/401 MDEyOklzc3VlQ29tbWVudDIxOTE4ODg5Nw== jhamman 2443309 2016-05-14T00:29:25Z 2016-05-14T00:29:25Z MEMBER

@shoyer - reading back in this thread (https://github.com/pydata/xarray/pull/401#issuecomment-96085330) you mentioned moving this fix to conventions.py and writing a dtype: bool attribute for bool typed variables. Do you still think that makes since?

Alternatively, we could just raise a warning when typecasting on write. This is the lazy but less intrusive way of operating.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle bool in NetCDF4 conversion 70805273
147809605 https://github.com/pydata/xarray/pull/401#issuecomment-147809605 https://api.github.com/repos/pydata/xarray/issues/401 MDEyOklzc3VlQ29tbWVudDE0NzgwOTYwNQ== jhamman 2443309 2015-10-13T18:45:57Z 2015-10-13T18:45:57Z MEMBER

@khaeru - do you think you're going to come back to this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle bool in NetCDF4 conversion 70805273
96082283 https://github.com/pydata/xarray/pull/401#issuecomment-96082283 https://api.github.com/repos/pydata/xarray/issues/401 MDEyOklzc3VlQ29tbWVudDk2MDgyMjgz jhamman 2443309 2015-04-24T22:24:39Z 2015-04-24T22:24:39Z MEMBER

How does this handle the round trip conversion from Dataset to netCDF and back to Dataset. Do you now get an array of u1?

Also, it may be good to add a unit test addressing your previous ValueError.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle bool in NetCDF4 conversion 70805273

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);