home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 219188897

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/401#issuecomment-219188897 https://api.github.com/repos/pydata/xarray/issues/401 219188897 MDEyOklzc3VlQ29tbWVudDIxOTE4ODg5Nw== 2443309 2016-05-14T00:29:25Z 2016-05-14T00:29:25Z MEMBER

@shoyer - reading back in this thread (https://github.com/pydata/xarray/pull/401#issuecomment-96085330) you mentioned moving this fix to conventions.py and writing a dtype: bool attribute for bool typed variables. Do you still think that makes since?

Alternatively, we could just raise a warning when typecasting on write. This is the lazy but less intrusive way of operating.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  70805273
Powered by Datasette · Queries took 0.725ms · About: xarray-datasette