issue_comments

Table actions

8 rows where issue = 692238160 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • open_zarr: concat_characters has no effect when dtype=U1 · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1111579013 https://github.com/pydata/xarray/issues/4405#issuecomment-1111579013 https://api.github.com/repos/pydata/xarray/issues/4405 IC_kwDOAMm_X85CQVmF stale[bot] 26384082 2022-04-27T23:37:46Z 2022-04-27T23:37:46Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686752919 https://github.com/pydata/xarray/issues/4405#issuecomment-686752919 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4Njc1MjkxOQ== eric-czech 6130352 2020-09-03T20:38:47Z 2020-09-03T20:38:47Z NONE

Np! Sounds good.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686750105 https://github.com/pydata/xarray/issues/4405#issuecomment-686750105 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4Njc1MDEwNQ== dcherian 2448579 2020-09-03T20:32:22Z 2020-09-03T20:32:22Z MEMBER

I think we keep it open for the U1 issue. I've renamed the title. Please change as you see fit.

Thanks for this and the other recent great bug reports :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686745468 https://github.com/pydata/xarray/issues/4405#issuecomment-686745468 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4Njc0NTQ2OA== eric-czech 6130352 2020-09-03T20:29:21Z 2020-09-03T20:29:21Z NONE

Hm got it. Should I close this out then or might there be something awry given that concatenation doesn't work with U1 types?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686722934 https://github.com/pydata/xarray/issues/4405#issuecomment-686722934 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4NjcyMjkzNA== dcherian 2448579 2020-09-03T19:56:53Z 2020-09-03T19:56:53Z MEMBER

I don't know. I suspect it's to deal with some netCDF string weirdness and the function signature was copied over from open_dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686716048 https://github.com/pydata/xarray/issues/4405#issuecomment-686716048 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4NjcxNjA0OA== eric-czech 6130352 2020-09-03T19:40:53Z 2020-09-03T19:40:53Z NONE

Also out of curiosity, do you know why that's True by default? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686715024 https://github.com/pydata/xarray/issues/4405#issuecomment-686715024 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4NjcxNTAyNA== eric-czech 6130352 2020-09-03T19:38:36Z 2020-09-03T19:38:36Z NONE

🤦 lol yes that works. Should U1 characters not also be concatenated when that's True? I.e. is this expected:

```python chrs = np.array([ ['A', 'B'], ['C', 'D'], ['E', 'F'], ], dtype='U1') ds = xr.Dataset(dict(x=(('dim0', 'dim1'), chrs))) ds.to_zarr('/tmp/test.zarr', mode='w') xr.open_zarr('/tmp/test.zarr', concat_characters=True).x.compute()

No concatenation occurs

<xarray.DataArray 'x' (dim0: 3, dim1: 2)> array([['A', 'B'], ['C', 'D'], ['E', 'F']], dtype='<U1') Dimensions without coordinates: dim0, dim1 ```

Basically, what does from_zarr consider to be a character?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160
686709931 https://github.com/pydata/xarray/issues/4405#issuecomment-686709931 https://api.github.com/repos/pydata/xarray/issues/4405 MDEyOklzc3VlQ29tbWVudDY4NjcwOTkzMQ== dcherian 2448579 2020-09-03T19:27:37Z 2020-09-03T19:27:37Z MEMBER

How about if you specified concat_characters=False?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_zarr: concat_characters has no effect when dtype=U1 692238160

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);