issue_comments: 686715024

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4405#issuecomment-686715024 https://api.github.com/repos/pydata/xarray/issues/4405 686715024 MDEyOklzc3VlQ29tbWVudDY4NjcxNTAyNA== 6130352 2020-09-03T19:38:36Z 2020-09-03T19:38:36Z NONE

🤦 lol yes that works. Should U1 characters not also be concatenated when that's True? I.e. is this expected:

```python chrs = np.array([ ['A', 'B'], ['C', 'D'], ['E', 'F'], ], dtype='U1') ds = xr.Dataset(dict(x=(('dim0', 'dim1'), chrs))) ds.to_zarr('/tmp/test.zarr', mode='w') xr.open_zarr('/tmp/test.zarr', concat_characters=True).x.compute()

No concatenation occurs

<xarray.DataArray 'x' (dim0: 3, dim1: 2)> array([['A', 'B'], ['C', 'D'], ['E', 'F']], dtype='<U1') Dimensions without coordinates: dim0, dim1 ```

Basically, what does from_zarr consider to be a character?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   692238160