issue_comments

Table actions

11 rows where issue = 669307837 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Fix indexing with datetime64[ns] with pandas=1.1 · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
693143777 https://github.com/pydata/xarray/pull/4292#issuecomment-693143777 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5MzE0Mzc3Nw== max-sixty 5635139 2020-09-16T03:11:48Z 2020-09-16T03:11:48Z MEMBER

I can do a patch release this weekend 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
693120001 https://github.com/pydata/xarray/pull/4292#issuecomment-693120001 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5MzEyMDAwMQ== shoyer 1217238 2020-09-16T01:45:35Z 2020-09-16T01:45:35Z MEMBER

Does this fix #4363?

No, that seems to be unrelated

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
693117098 https://github.com/pydata/xarray/pull/4292#issuecomment-693117098 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5MzExNzA5OA== seth-p 7441788 2020-09-16T01:34:08Z 2020-09-16T01:34:08Z CONTRIBUTOR

Does this fix #4363?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
693117062 https://github.com/pydata/xarray/pull/4292#issuecomment-693117062 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5MzExNzA2Mg== shoyer 1217238 2020-09-16T01:34:00Z 2020-09-16T01:34:00Z MEMBER

OK, submitting this!

Thanks @keewis for making this fix actually work :)

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 3,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
666846665 https://github.com/pydata/xarray/pull/4292#issuecomment-666846665 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY2Njg0NjY2NQ== pep8speaks 24736507 2020-07-31T00:49:06Z 2020-09-16T00:31:04Z NONE

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-09-16 00:31:04 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
692951623 https://github.com/pydata/xarray/pull/4292#issuecomment-692951623 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5Mjk1MTYyMw== dcherian 2448579 2020-09-15T20:09:10Z 2020-09-15T20:09:10Z MEMBER

I am +1 on merging this quickly and issuing a bugfix release.

We can always make cleanups later...

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
691656286 https://github.com/pydata/xarray/pull/4292#issuecomment-691656286 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5MTY1NjI4Ng== keewis 14808389 2020-09-13T10:58:59Z 2020-09-13T21:56:22Z MEMBER

it seems we have to cast because label may also be something like a Variable object, which is not accepted by index.get_loc. I pushed my original fix (falling back to .item() for non-datetime / timedelta dtypes), I hope that's okay?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
691665611 https://github.com/pydata/xarray/pull/4292#issuecomment-691665611 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY5MTY2NTYxMQ== keewis 14808389 2020-09-13T12:29:44Z 2020-09-13T12:29:44Z MEMBER

it seems pandas warns about our usage of pandas.Grouper: ``` /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4292/xarray/core/common.py:1134: FutureWarning: 'base' in .resample() and in Grouper() is deprecated. The new arguments that you should use are 'offset' or 'origin'.

df.resample(freq="3s", base=2)

becomes:

df.resample(freq="3s", offset="2s")

grouper = pd.Grouper( `` this was introduced in1.1.0. We're supportingpandas>=0.25(maybe even>=0.24`) so we can't switch yet. I added a warning filter and a todo comment, but we might also need a tracking issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
687749906 https://github.com/pydata/xarray/pull/4292#issuecomment-687749906 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY4Nzc0OTkwNg== keewis 14808389 2020-09-06T10:25:56Z 2020-09-06T10:25:56Z MEMBER

gentle ping, @shoyer. Any updates on this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
682420487 https://github.com/pydata/xarray/pull/4292#issuecomment-682420487 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY4MjQyMDQ4Nw== keewis 14808389 2020-08-28T09:13:42Z 2020-08-28T09:13:42Z MEMBER

there are lots of people that stumble into this, so I think it might be good to get this to work as soon as possible and issue a bugfix release.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837
669162768 https://github.com/pydata/xarray/pull/4292#issuecomment-669162768 https://api.github.com/repos/pydata/xarray/issues/4292 MDEyOklzc3VlQ29tbWVudDY2OTE2Mjc2OA== keewis 14808389 2020-08-05T12:25:10Z 2020-08-05T14:29:38Z MEMBER

you should be able to isolate this to just indexing.convert_label_indexer, e.g. with this in test_indexing.py: ```python def test_convert_label_indexer_datetime(self): index = pd.to_datetime(["2000-01-01", "2001-01-01", "2002-01-01"]) actual = indexing.convert_label_indexer(index, "2001-01-01") expected = (1, None) assert actual == expected

    actual = indexing.convert_label_indexer(index, index.to_numpy()[1])
    assert actual == expected

```

The failing tests are due to label[()] returning a numpy.str_ instead of a plain python str. Maybe we can fix that by using item as long as the dtype is not "datetime64" or "timedelta64": python if label.dtype.kind in "mM": label_value = label[()] else: label_value = label.item() Edit: stable is affected by this, too

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix indexing with datetime64[ns] with pandas=1.1 669307837

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);