issue_comments: 691665611

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4292#issuecomment-691665611 https://api.github.com/repos/pydata/xarray/issues/4292 691665611 MDEyOklzc3VlQ29tbWVudDY5MTY2NTYxMQ== 14808389 2020-09-13T12:29:44Z 2020-09-13T12:29:44Z MEMBER

it seems pandas warns about our usage of pandas.Grouper: ``` /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4292/xarray/core/common.py:1134: FutureWarning: 'base' in .resample() and in Grouper() is deprecated. The new arguments that you should use are 'offset' or 'origin'.

df.resample(freq="3s", base=2)

becomes:

df.resample(freq="3s", offset="2s")

grouper = pd.Grouper( `` this was introduced in1.1.0. We're supportingpandas>=0.25(maybe even>=0.24`) so we can't switch yet. I added a warning filter and a todo comment, but we might also need a tracking issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   669307837