issue_comments

Table actions

4 rows where issue = 619327957 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • make text wrap width an argument in label_from_attrs · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1484208242 https://github.com/pydata/xarray/pull/4067#issuecomment-1484208242 https://api.github.com/repos/pydata/xarray/issues/4067 IC_kwDOAMm_X85Ydzhy dcherian 2448579 2023-03-26T20:06:28Z 2023-03-26T20:06:28Z MEMBER

Sorry but this function isn't public API. I recommend copying it over to your code .

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make text wrap width an argument in label_from_attrs 619327957
685859785 https://github.com/pydata/xarray/pull/4067#issuecomment-685859785 https://api.github.com/repos/pydata/xarray/issues/4067 MDEyOklzc3VlQ29tbWVudDY4NTg1OTc4NQ== aspitarl 20617032 2020-09-02T16:44:06Z 2020-09-02T16:44:06Z NONE

@TomNicholas Hi, any update on this being able to get implemented? Should I resolve the merge conflicts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make text wrap width an argument in label_from_attrs 619327957
630590932 https://github.com/pydata/xarray/pull/4067#issuecomment-630590932 https://api.github.com/repos/pydata/xarray/issues/4067 MDEyOklzc3VlQ29tbWVudDYzMDU5MDkzMg== aspitarl 20617032 2020-05-19T05:34:28Z 2020-05-19T05:34:28Z NONE

I have no plans to alter xarray further in ways that make use of this function. I have simply been importing the function for use on its own in scripts/notebooks and have needed to change the wrap width. I don't think it necessarily needs to be added to the public API. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make text wrap width an argument in label_from_attrs 619327957
630447144 https://github.com/pydata/xarray/pull/4067#issuecomment-630447144 https://api.github.com/repos/pydata/xarray/issues/4067 MDEyOklzc3VlQ29tbWVudDYzMDQ0NzE0NA== TomNicholas 35968931 2020-05-18T21:33:45Z 2020-05-18T21:33:45Z MEMBER

Hi Lee, thanks for this.

I only had the mypy and flake8 linters and figured that was good enough for a minor change like this.

As the tests all passed then that means the changes fit those style requirements :)

And I didn't see label_from_attrs in the api document so just added a line to whats-new.rst

So label_from_attrs isn't public API, which we could change, but should be considered. If we make it public API, then we would need to not change/delete it in future between versions without warning, otherwise some users' code (such as yours) would break unexpectedly.

This additional maintenance needs to be weighed against the advantages of making the function public API. Are you planning to change something else within xarray that will later use this change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make text wrap width an argument in label_from_attrs 619327957

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);