issue_comments: 630447144

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4067#issuecomment-630447144 https://api.github.com/repos/pydata/xarray/issues/4067 630447144 MDEyOklzc3VlQ29tbWVudDYzMDQ0NzE0NA== 35968931 2020-05-18T21:33:45Z 2020-05-18T21:33:45Z MEMBER

Hi Lee, thanks for this.

I only had the mypy and flake8 linters and figured that was good enough for a minor change like this.

As the tests all passed then that means the changes fit those style requirements :)

And I didn't see label_from_attrs in the api document so just added a line to whats-new.rst

So label_from_attrs isn't public API, which we could change, but should be considered. If we make it public API, then we would need to not change/delete it in future between versions without warning, otherwise some users' code (such as yours) would break unexpectedly.

This additional maintenance needs to be weighed against the advantages of making the function public API. Are you planning to change something else within xarray that will later use this change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   619327957