issue_comments

Table actions

5 rows where issue = 606549469 and user = 40136154 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • pnijhara · 5 ✖

issue 1

  • Remove dangerous default argument · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
619403922 https://github.com/pydata/xarray/issues/4002#issuecomment-619403922 https://api.github.com/repos/pydata/xarray/issues/4002 MDEyOklzc3VlQ29tbWVudDYxOTQwMzkyMg== pnijhara 40136154 2020-04-25T16:19:26Z 2020-04-25T16:19:26Z CONTRIBUTOR

Agreed with that. So, should I open another issue for asserts or not?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove dangerous default argument 606549469
619358326 https://github.com/pydata/xarray/issues/4002#issuecomment-619358326 https://api.github.com/repos/pydata/xarray/issues/4002 MDEyOklzc3VlQ29tbWVudDYxOTM1ODMyNg== pnijhara 40136154 2020-04-25T10:37:05Z 2020-04-25T10:37:05Z CONTRIBUTOR

@shoyer, I partially agree with your statement that " assert is the appropriate way to verify internal invariants". This is correct but not every time. When you see the link that you shared it also shows that most of the assert statements are used in tests and not in simple files.

Let me quote again "Since assert provides an easy way to check some condition and fail execution, it’s very common for developers to use it to check validity. But when the Python interpreter is invoked with the -O (optimize) flag, the assert statements are removed from the bytecode. So, if assert statements are used for user-facing validation in production code, the block won’t be executed at all — potentially opening up a security vulnerability. It is recommended to use assert statements only in tests."

Again it's just a suggestion IMHO

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove dangerous default argument 606549469
619320551 https://github.com/pydata/xarray/issues/4002#issuecomment-619320551 https://api.github.com/repos/pydata/xarray/issues/4002 MDEyOklzc3VlQ29tbWVudDYxOTMyMDU1MQ== pnijhara 40136154 2020-04-25T04:51:10Z 2020-04-25T04:52:30Z CONTRIBUTOR

I might be behind the curve on the pythonic approach there: what's wrong with asserts there?

As far as I know, assert should not be used outside of tests because while running python with -O (optimize) flag, it will remove the assert statements.

Will open a separate issue for this. We should have a discussion over asserts over there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove dangerous default argument 606549469
619320043 https://github.com/pydata/xarray/issues/4002#issuecomment-619320043 https://api.github.com/repos/pydata/xarray/issues/4002 MDEyOklzc3VlQ29tbWVudDYxOTMyMDA0Mw== pnijhara 40136154 2020-04-25T04:46:09Z 2020-04-25T04:46:09Z CONTRIBUTOR

We would take a PR to change these to default None and then x=x or {}

I like this pattern a little better, because it's clear it's comparing to a default value:

python if x is None: x = {}

@shoyer I was thinking of the same. Will send a PR with this change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove dangerous default argument 606549469
619215393 https://github.com/pydata/xarray/issues/4002#issuecomment-619215393 https://api.github.com/repos/pydata/xarray/issues/4002 MDEyOklzc3VlQ29tbWVudDYxOTIxNTM5Mw== pnijhara 40136154 2020-04-24T20:04:58Z 2020-04-24T20:04:58Z CONTRIBUTOR

Same can also be found in xarray/tests/test_backends.py python 3621 ny=3, 3622 nz=3, 3623 transform=None, 3624 transform_args=[5000, 80000, 1000, 2000.0],3625 crs={"units": "m", "no_defs": True, "ellps": "WGS84", "proj": "utm", "zone": 18}, 3626 open_kwargs=None, 3627 additional_attrs=None,

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove dangerous default argument 606549469

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);