home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 619320551

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4002#issuecomment-619320551 https://api.github.com/repos/pydata/xarray/issues/4002 619320551 MDEyOklzc3VlQ29tbWVudDYxOTMyMDU1MQ== 40136154 2020-04-25T04:51:10Z 2020-04-25T04:52:30Z CONTRIBUTOR

I might be behind the curve on the pythonic approach there: what's wrong with asserts there?

As far as I know, assert should not be used outside of tests because while running python with -O (optimize) flag, it will remove the assert statements.

Will open a separate issue for this. We should have a discussion over asserts over there.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  606549469
Powered by Datasette · Queries took 0.75ms · About: xarray-datasette